From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFqXb-0007l5-AI for qemu-devel@nongnu.org; Mon, 26 Jan 2015 15:45:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFqXX-0001Ix-Bz for qemu-devel@nongnu.org; Mon, 26 Jan 2015 15:45:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFqXX-0001Ir-1J for qemu-devel@nongnu.org; Mon, 26 Jan 2015 15:45:43 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0QKjfi1006404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 26 Jan 2015 15:45:42 -0500 Message-ID: <54C6A773.1090903@redhat.com> Date: Mon, 26 Jan 2015 15:45:39 -0500 From: Max Reitz MIME-Version: 1.0 References: <1421397983-28065-1-git-send-email-famz@redhat.com> <1421397983-28065-6-git-send-email-famz@redhat.com> In-Reply-To: <1421397983-28065-6-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 5/5] qemu-iotests: Add 093 for IO throttling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 2015-01-16 at 03:46, Fam Zheng wrote: > This case utilizes qemu-io command "aio_{read,write} -q" to verify the > effectiveness of IO throttling options. > > It's implemented by driving the vm timer from qtest protocol, so the > throttling timers are signaled with determinied time duration. Then we > verify the completed IO requests are within 10% error of bps and iops > limits. > > "null" protocol is used as the disk backend so that no actual disk IO is > performed on host, this will make the blockstats much more > deterministic. Both "null-aio" and "null-co" are covered, which is also > a simple cross validation test for the driver code. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/093 | 103 +++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/093.out | 5 +++ > tests/qemu-iotests/group | 1 + > 3 files changed, 109 insertions(+) > create mode 100755 tests/qemu-iotests/093 > create mode 100644 tests/qemu-iotests/093.out NACK. This literally kills my laptop (I can recover when running this test in tmpfs (for some reason inexplicable to me, since this uses the null block drivers...), but I cannot when running it on my HDD). Would it be possible to use larger requests and smaller iops? (Or just the same request size but smaller bps as well) PS: Feel free to tell me I'm doing something wrong, of course. But just ./check -T -raw -c writethrough 093 just killed my laptop, and simply ./check -raw 093 would have probably killed it, too, if I wouldn't have held down ^C after some seconds (I'm listening to music and that's when it began stuttering...). > diff --git a/tests/qemu-iotests/093 b/tests/qemu-iotests/093 > new file mode 100755 > index 0000000..d12cc25 > --- /dev/null > +++ b/tests/qemu-iotests/093 > @@ -0,0 +1,103 @@ > +#!/usr/bin/env python > +# > +# Tests for IO throttling > +# > +# Copyright (C) 2015 Red Hat, Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > +# > + > +import iotests > + > +class ThrottleTestCase(iotests.QMPTestCase): > + test_img = "null-aio://" > + > + def blockstats(self, device): > + result = self.vm.qmp("query-blockstats") > + for r in result['return']: > + if r['device'] == device: > + stat = r['stats'] > + return stat['rd_bytes'], stat['rd_operations'], stat['wr_bytes'], stat['wr_operations'] > + raise Exception("Device not found for blockstats: %s" % device) > + > + def setUp(self): > + self.vm = iotests.VM().add_drive(self.test_img) > + self.vm.launch() > + > + def tearDown(self): > + self.vm.shutdown() > + > + def do_test_throttle(self, seconds, params): > + def check_limit(limit, num): > + # IO throttling algorithm is discrete, allow 10% error so the test > + # is more "more robust"? Max