From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFvaI-00074b-Lu for qemu-devel@nongnu.org; Mon, 26 Jan 2015 21:08:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFvaF-00051e-BI for qemu-devel@nongnu.org; Mon, 26 Jan 2015 21:08:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFvaF-00051V-2G for qemu-devel@nongnu.org; Mon, 26 Jan 2015 21:08:51 -0500 Message-ID: <54C6F32D.3040307@redhat.com> Date: Mon, 26 Jan 2015 21:08:45 -0500 From: Max Reitz MIME-Version: 1.0 References: <1422284444-12529-1-git-send-email-mreitz@redhat.com> <1422284444-12529-4-git-send-email-mreitz@redhat.com> <54C6C1C1.9070104@redhat.com> In-Reply-To: <54C6C1C1.9070104@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 03/14] blockdev: Use blk_new_open() in blockdev_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi , Stefano Stabellini On 2015-01-26 at 17:37, Eric Blake wrote: > On 01/26/2015 08:00 AM, Max Reitz wrote: >> Due to different error propagation, this breaks tests 051 and 087; fix >> their output. >> >> Signed-off-by: Max Reitz >> --- >> blockdev.c | 92 +++++++++++++++++++++------------------------- >> tests/qemu-iotests/051.out | 60 +++++++++++++++--------------- >> tests/qemu-iotests/087.out | 8 ++-- >> 3 files changed, 76 insertions(+), 84 deletions(-) >> >> Testing: -drive file=TEST_DIR/t.qcow2,driver=raw,format=qcow2 >> -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=raw,format=qcow2: could not open disk image TEST_DIR/t.qcow2: Driver specified twice >> +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=raw,format=qcow2: Cannot specify both 'driver' and 'format' > Is it possible to specify driver=qcow2,format=qcow2? Should it be? No, it isn't, and in my opinion it shouldn't be (just a personal feeling, though). > Either way, are we testing the outcome of that? (that is, there is a > difference between two competing options, and two spellings of the same > option - I could go for either rejecting the duplication, or for > allowing it when the two are the same, whichever is easier, but would > like to make sure it is tested so we know if we change our minds later > whether we are risking a regression). No, we aren't yet. Albeit not really related to this series, it is a good point, so I'll probably just add a test case in v4. >> >> >> === Specifying both an option and its legacy alias === >> @@ -323,13 +323,13 @@ QEMU_PROG: -drive file=TEST_DIR/t.qcow2,readonly=on,read-only=off: 'read-only' a >> === Parsing protocol from file name === >> >> Testing: -hda foo:bar >> -QEMU_PROG: -hda foo:bar: could not open disk image foo:bar: Unknown protocol >> +QEMU_PROG: -hda foo:bar: Unknown protocol > Not the fault of this patch, but can this error message be improved? > Even 'Unknown protocol: foo' would read better. Indeed, I'll fix it. > All of the other shorter error messages still seem to read fine, and the > decrease in verbosity could be argued as a feature. So overall, I'm > fine with this patch. > > Reviewed-by: Eric Blake > Thank you! Max