From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFvwY-0005n2-W9 for qemu-devel@nongnu.org; Mon, 26 Jan 2015 21:31:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFvwV-000401-OU for qemu-devel@nongnu.org; Mon, 26 Jan 2015 21:31:54 -0500 Received: from mail-pd0-f169.google.com ([209.85.192.169]:56898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFvwV-0003za-Jh for qemu-devel@nongnu.org; Mon, 26 Jan 2015 21:31:51 -0500 Received: by mail-pd0-f169.google.com with SMTP id g10so15892926pdj.0 for ; Mon, 26 Jan 2015 18:31:50 -0800 (PST) Message-ID: <54C6F88D.8000705@ozlabs.ru> Date: Tue, 27 Jan 2015 13:31:41 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1422316341-28983-1-git-send-email-dvaleev@suse.de> In-Reply-To: <1422316341-28983-1-git-send-email-dvaleev@suse.de> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Update boot_order on reset for sPAPR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: dvaleev@suse.de, qemu-devel@nongnu.org Cc: Gonglei , qemu-ppc@nongnu.org, Alexander Graf , armbru@redhat.com On 01/27/2015 10:52 AM, dvaleev@suse.de wrote: > This is cleaner attempt to fix -boot once=X behaviour on sPAPR > > qemu-system-ppc64 -m 1024 -enable-kvm -boot once=d -vga none -nographic > Ready! > 0 > dev /chosen ok > 0 > .properties > stdout 3e512100 > .... > ibm,architecture-vec-5 00000000 0080 > qemu,boot-device d > 6400 > linux,stdout-path /vdevice/vty@71000000 > .... > 0 > reset-all > .... > Ready! > 0 > dev /chosen ok > 0 > .properties > stdout 3e512100 > .... > ibm,architecture-vec-5 00000000 0080 > linux,stdout-path /vdevice/vty@71000000 > > Compared to previous patch set, this one doesn't implement register_boot_set for sPAPR, > but instead updates boot_order at MachineState and read it on each guest's reset. Looks good to me. Reviewed-by: Alexey Kardashevskiy -- Alexey