From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG25s-0007Bo-PB for qemu-devel@nongnu.org; Tue, 27 Jan 2015 04:05:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YG25p-0000BL-Da for qemu-devel@nongnu.org; Tue, 27 Jan 2015 04:05:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG25p-0000BF-5w for qemu-devel@nongnu.org; Tue, 27 Jan 2015 04:05:53 -0500 Message-ID: <54C754E5.3070501@redhat.com> Date: Tue, 27 Jan 2015 10:05:41 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1422324179-32106-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1422324179-32106-1-git-send-email-mreitz@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] nbd: iotest fixes and error message improvement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi On 27/01/2015 03:02, Max Reitz wrote: > This series is a follow-up to my previous patch "iotests: Specify format > for qemu-nbd" and as such relies on it. > > The first three patches of this series fix the qemu-iotests so they once > again pass when using NBD. > > The fourth patch of this series improves NBD's error message for > establishing connections, especially if the server's and the client's > NBD version differs (which, until now, was simply "Bad magic received"). Good idea! > Max Reitz (4): > iotests: Fix 083 > iotests: Fix 100 for nbd > iotests: Fix 104 for NBD > nbd: Improve error messages > > block/nbd-client.c | 4 +- > block/nbd-client.h | 2 +- > block/nbd.c | 2 +- > include/block/nbd.h | 2 +- > nbd.c | 42 ++++++++++++--------- > qemu-nbd.c | 7 +++- > tests/qemu-iotests/083 | 3 +- > tests/qemu-iotests/083.out | 81 ++++++++++++++-------------------------- > tests/qemu-iotests/100 | 12 ++++++ > tests/qemu-iotests/104 | 9 ++--- > tests/qemu-iotests/common.filter | 1 + > 11 files changed, 82 insertions(+), 83 deletions(-) > Reviewed-by: Paolo Bonzini