From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG3dB-00062Q-Ou for qemu-devel@nongnu.org; Tue, 27 Jan 2015 05:44:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YG3d8-00018y-Dl for qemu-devel@nongnu.org; Tue, 27 Jan 2015 05:44:25 -0500 Received: from mail.uni-paderborn.de ([131.234.142.9]:41908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG3d8-00018u-6p for qemu-devel@nongnu.org; Tue, 27 Jan 2015 05:44:22 -0500 Message-ID: <54C77A53.1000307@mail.uni-paderborn.de> Date: Tue, 27 Jan 2015 11:45:23 +0000 From: Bastian Koppelmann MIME-Version: 1.0 References: <1422302600-21514-1-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 0/9] tricore patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On 01/27/2015 10:40 AM, Peter Maydell wrote: > On 26 January 2015 at 20:03, Bastian Koppelmann > wrote: >> The following changes since commit 1ac0206b2ae1ffaeec564f110664a3a77bafafd2: >> >> qemu-timer.c: Trim list of included headers (2015-01-26 18:15:54 +0000) >> >> are available in the git repository at: >> >> https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore20150126-2 >> >> for you to fetch changes up to 24c3bf03341ada63a0728f2bdfd2b7c226ad958e: >> >> target-tricore: Add instructions of RRR opcode format (2015-01-26 19:56:46 +0000) >> >> ---------------------------------------------------------------- >> tricore bugfixes and RR1, RR2, RRPW and RRR insn >> >> ---------------------------------------------------------------- > Looks like this would introduce a new clang warning: > > /home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23: > warning: equality > comparison with extraneous parentheses [-Wparentheses-equality] > if ((up_shift == 32)) { > ~~~~~~~~~^~~~~ > /home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23: > note: remove extraneous > parentheses around the comparison to silence this warning > if ((up_shift == 32)) { > ~ ^ ~ > /home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23: > note: use '=' to turn > this equality comparison into an assignment > if ((up_shift == 32)) { > ^~ > = > > We've nearly managed to eradicate all our clang warnings so I > don't want to add more at this point -- could you fix this > and resend the pullreq, please? Sure thing. With this many clang warning, I think I should also build with clang on my machine too. Cheers, Bastian > thanks > -- PMM