From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49345)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1YG6AQ-0002Ba-M7
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 08:26:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1YG6AN-0003tf-Fw
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 08:26:54 -0500
Received: from lhrrgout.huawei.com ([194.213.3.17]:16038)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1YG6AN-0003tD-1H
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 08:26:51 -0500
Message-ID: <54C7920A.3000308@huawei.com>
Date: Tue, 27 Jan 2015 14:26:34 +0100
From: Claudio Fontana <claudio.fontana@huawei.com>
MIME-Version: 1.0
References: <1421938231-25698-1-git-send-email-imammedo@redhat.com>
	<1421938231-25698-22-git-send-email-imammedo@redhat.com>
In-Reply-To: <1421938231-25698-22-git-send-email-imammedo@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 21/47] acpi: add
	acpi_resource_template() helper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, drjones@redhat.com, marcel.a@redhat.com, mst@redhat.com

Hello Igor,

On 22.01.2015 15:50, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  hw/acpi/acpi-build-utils.c         | 8 ++++++++
>  include/hw/acpi/acpi-build-utils.h | 1 +
>  2 files changed, 9 insertions(+)
> 
> diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c
> index 2d5e77a..32a4377 100644
> --- a/hw/acpi/acpi-build-utils.c
> +++ b/hw/acpi/acpi-build-utils.c
> @@ -493,6 +493,14 @@ AcpiAml GCC_FMT_ATTR(1, 2) acpi_device(const char *name_format, ...)
>      return var;
>  }
> 

> +/* ResourceTemplate marcos helper */

Since you have been so careful about putting references to the spec everywhere else,
what about adding something for ResourceTemplate macros too (note typo above)?

For example 19.2.3 "ASL Resource Templates" if that's the right one. (I am looking at version 5.1)

Thanks,

Claudio

> +AcpiAml acpi_resource_template(void)
> +{
> +    /* ResourceTemplate is a buffer of Resources with EndTag at the end */
> +    AcpiAml var = aml_allocate_internal(0x11 /* BufferOp */, RES_TEMPLATE);
> +    return var;
> +}
> +
>  /* ACPI 5.0: 20.2.5.4 Type 2 Opcodes Encoding: DefBuffer */
>  AcpiAml acpi_buffer(void)
>  {
> diff --git a/include/hw/acpi/acpi-build-utils.h b/include/hw/acpi/acpi-build-utils.h
> index a79c085..594fae7 100644
> --- a/include/hw/acpi/acpi-build-utils.h
> +++ b/include/hw/acpi/acpi-build-utils.h
> @@ -46,6 +46,7 @@ AcpiAml acpi_method(const char *name, int arg_count);
>  AcpiAml GCC_FMT_ATTR(1, 2) acpi_scope(const char *name_format, ...);
>  AcpiAml GCC_FMT_ATTR(1, 2) acpi_device(const char *name_format, ...);
>  AcpiAml acpi_buffer(void);
> +AcpiAml acpi_resource_template(void);
>  AcpiAml acpi_package(uint8_t num_elements);
>  
>  /* other helpers */
>