From: Claudio Fontana <claudio.fontana@huawei.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Alvise Rigo <a.rigo@virtualopensystems.com>,
Stuart Yoder <stuart.yoder@freescale.com>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine
Date: Tue, 27 Jan 2015 15:37:14 +0100 [thread overview]
Message-ID: <54C7A29A.9000608@huawei.com> (raw)
In-Reply-To: <CAFEAcA9QAFb6Nikgstirb6wn3_4YwbTRrwX7DLj=cJQ+Pn3tfw@mail.gmail.com>
On 27.01.2015 11:09, Peter Maydell wrote:
> On 27 January 2015 at 09:24, Claudio Fontana <claudio.fontana@huawei.com> wrote:
>> On 22.01.2015 16:52, Alexander Graf wrote:
>>> On 22.01.15 16:28, Claudio Fontana wrote:
>>>> Alex wrote;
>>>>> + for (devfn = 0; devfn <= 0x18; devfn+=0x8) {
>>>>
>>>> devfn += 0x8 (spaces)
>>>
>>> Yeah, I had it like that and it looked uglier. I guess it's a matter of
>>> personal preference?
>>
>> You don't have coding standards for this ?
>
> Not formal ones, but (a) I think += should have spaces aronud
> it and (b) I'm a bit surprised if checkpatch doesn't catch
> this (it certainly attempts to...)
>
> -- PMM
It does:
ERROR: spaces required around that '+=' (ctx:VxV)
#167: FILE: hw/arm/virt.c:571:
+ for (devfn = 0; devfn <= 0x18; devfn+=0x8) {
^
Claudio
next prev parent reply other threads:[~2015-01-27 14:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 16:18 [Qemu-devel] [PATCH v2 0/4] ARM: Add support for a generic PCI Express host bridge Alexander Graf
2015-01-21 16:18 ` [Qemu-devel] [PATCH v2 1/4] pci: Split pcie_host_mmcfg_map() Alexander Graf
2015-01-27 13:55 ` Peter Maydell
2015-01-27 14:24 ` Michael S. Tsirkin
2015-01-27 14:40 ` Paolo Bonzini
2015-01-21 16:18 ` [Qemu-devel] [PATCH v2 2/4] pci: Add generic PCIe host bridge Alexander Graf
2015-01-22 16:32 ` B02008
2015-01-27 15:31 ` Peter Maydell
2015-01-29 13:59 ` Alexander Graf
2015-01-29 14:25 ` Peter Maydell
2015-01-30 10:25 ` Paolo Bonzini
2015-01-21 16:18 ` [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine Alexander Graf
2015-01-22 15:28 ` Claudio Fontana
2015-01-22 15:52 ` Alexander Graf
2015-01-27 9:24 ` Claudio Fontana
2015-01-27 10:09 ` Peter Maydell
2015-01-27 14:37 ` Claudio Fontana [this message]
2015-01-27 16:52 ` Peter Maydell
2015-01-29 14:31 ` Alexander Graf
2015-01-29 14:34 ` Peter Maydell
2015-01-29 14:37 ` Alexander Graf
2015-01-29 14:45 ` Peter Maydell
2015-01-29 14:49 ` Alexander Graf
2015-01-21 16:18 ` [Qemu-devel] [PATCH v2 4/4] pci: Move PCI VGA to pci.mak Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C7A29A.9000608@huawei.com \
--to=claudio.fontana@huawei.com \
--cc=a.rigo@virtualopensystems.com \
--cc=agraf@suse.de \
--cc=ard.biesheuvel@linaro.org \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rob.herring@linaro.org \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).