From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42182)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1YG7Gs-0003Sr-G6
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 09:37:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1YG7Gn-00054c-TY
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 09:37:38 -0500
Received: from lhrrgout.huawei.com ([194.213.3.17]:31079)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1YG7Gn-00054K-Ky
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 09:37:33 -0500
Message-ID: <54C7A29A.9000608@huawei.com>
Date: Tue, 27 Jan 2015 15:37:14 +0100
From: Claudio Fontana <claudio.fontana@huawei.com>
MIME-Version: 1.0
References: <1421857131-18539-1-git-send-email-agraf@suse.de>
	<1421857131-18539-4-git-send-email-agraf@suse.de>
	<54C1171D.1000500@huawei.com> <54C11CAD.6030109@suse.de>
	<54C75957.9070809@huawei.com>
	<CAFEAcA9QAFb6Nikgstirb6wn3_4YwbTRrwX7DLj=cJQ+Pn3tfw@mail.gmail.com>
In-Reply-To: <CAFEAcA9QAFb6Nikgstirb6wn3_4YwbTRrwX7DLj=cJQ+Pn3tfw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt
	machine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Alvise Rigo <a.rigo@virtualopensystems.com>, Stuart Yoder <stuart.yoder@freescale.com>, Alexander Graf <agraf@suse.de>

On 27.01.2015 11:09, Peter Maydell wrote:
> On 27 January 2015 at 09:24, Claudio Fontana <claudio.fontana@huawei.com> wrote:
>> On 22.01.2015 16:52, Alexander Graf wrote:
>>> On 22.01.15 16:28, Claudio Fontana wrote:
>>>> Alex wrote;
>>>>> +    for (devfn = 0; devfn <= 0x18; devfn+=0x8) {
>>>>
>>>> devfn += 0x8 (spaces)
>>>
>>> Yeah, I had it like that and it looked uglier. I guess it's a matter of
>>> personal preference?
>>
>> You don't have coding standards for this ?
> 
> Not formal ones, but (a) I think += should have spaces aronud
> it and (b) I'm a bit surprised if checkpatch doesn't catch
> this (it certainly attempts to...)
> 
> -- PMM

It does:

ERROR: spaces required around that '+=' (ctx:VxV)
#167: FILE: hw/arm/virt.c:571:
+    for (devfn = 0; devfn <= 0x18; devfn+=0x8) {
                                         ^

Claudio