From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51332)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YG7v2-0000ed-1Z
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 10:19:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YG7uz-0003QD-Ax
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 10:19:07 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36251)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YG7uz-0003Py-3t
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 10:19:05 -0500
Message-ID: <54C7A82E.3060801@redhat.com>
Date: Tue, 27 Jan 2015 10:01:02 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1422284444-12529-1-git-send-email-mreitz@redhat.com>
	<1422284444-12529-7-git-send-email-mreitz@redhat.com>
	<54C7008C.8090007@redhat.com>
In-Reply-To: <54C7008C.8090007@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 06/14] qemu-img: Use blk_new_open() in
 img_rebase()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

On 2015-01-26 at 22:05, Eric Blake wrote:
> On 01/26/2015 08:00 AM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   qemu-img.c | 57 ++++++++++++++++++++++++---------------------------------
>>   1 file changed, 24 insertions(+), 33 deletions(-)
>>
>> -
>>       /* For safe rebasing we need to compare old and new backing file */
>>       if (!unsafe) {
>>           char backing_name[PATH_MAX];
>> +        QDict *options = NULL;
>> +
>> +        if (!unsafe && bs->backing_format[0] != '\0') {
> Useless conditional ('!unsafe' is always true here).

Oh, right, thanks.

Max

> With that fixed,
> Reviewed-by: Eric Blake <eblake@redhat.com>