From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG9La-0000LI-VK for qemu-devel@nongnu.org; Tue, 27 Jan 2015 11:50:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YG9LX-0006JB-I6 for qemu-devel@nongnu.org; Tue, 27 Jan 2015 11:50:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG9LX-0006Il-Aj for qemu-devel@nongnu.org; Tue, 27 Jan 2015 11:50:35 -0500 Message-ID: <54C7C1D0.8070406@redhat.com> Date: Tue, 27 Jan 2015 11:50:24 -0500 From: Max Reitz MIME-Version: 1.0 References: <1422366699-17473-1-git-send-email-den@openvz.org> <1422366699-17473-2-git-send-email-den@openvz.org> In-Reply-To: <1422366699-17473-2-git-send-email-den@openvz.org> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/7] block/raw-posix: create translate_err helper to merge errno values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Kevin Wolf , Peter Lieven , Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi On 2015-01-27 at 08:51, Denis V. Lunev wrote: > actually the code > if (ret == -ENODEV || ret == -ENOSYS || ret == -EOPNOTSUPP || > ret == -ENOTTY) { > ret = -ENOTSUP; > } > is present twice and will be added a couple more times. Create helper > for this. > > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > CC: Stefan Hajnoczi > CC: Peter Lieven > CC: Fam Zheng > --- > block/raw-posix.c | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) Reviewed-by: Max Reitz