From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46412)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YG9Ry-0000CD-BD
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 11:57:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YG9Rt-0008SI-Pc
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 11:57:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43631)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YG9Rt-0008SE-HM
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 11:57:09 -0500
Message-ID: <54C7C35D.20103@redhat.com>
Date: Tue, 27 Jan 2015 11:57:01 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1422366699-17473-1-git-send-email-den@openvz.org>
	<1422366699-17473-3-git-send-email-den@openvz.org>
In-Reply-To: <1422366699-17473-3-git-send-email-den@openvz.org>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/7] block/raw-posix: create do_fallocate
 helper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 2015-01-27 at 08:51, Denis V. Lunev wrote:
> The pattern
>      do {
>          if (fallocate(s->fd, mode, offset, len) == 0) {
>              return 0;
>          }
>      } while (errno == EINTR);
>      ret = translate_err(-errno);
> will be commonly useful in next patches. Create helper for it.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Peter Lieven <pl@kamp.de>
> CC: Fam Zheng <famz@redhat.com>
> ---
>   block/raw-posix.c | 22 ++++++++++++++--------
>   1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index 24300d0..2aa268a 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -902,6 +902,18 @@ static int translate_err(int err)
>       return err;
>   }
>   
> +#if defined(CONFIG_FALLOCATE_PUNCH_HOLE)
> +static int do_fallocate(int fd, int mode, off_t offset, off_t len)
> +{
> +    do {
> +        if (fallocate(fd, mode, offset, len) == 0) {
> +            return 0;
> +        }
> +    } while (errno == EINTR);
> +    return translate_err(-errno);

The translate_err() seems superfluous so far, but won't hurt and I guess 
the redundancy will disappear in a later patch of this series.

Reviewed-by: Max Reitz <mreitz@redhat.com>