From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGAVs-0002Mn-Hd for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:05:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGAVp-0000pZ-6u for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:05:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGAVp-0000pD-0j for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:05:17 -0500 Message-ID: <54C7D354.2030003@redhat.com> Date: Tue, 27 Jan 2015 13:05:08 -0500 From: Max Reitz MIME-Version: 1.0 References: <1422366699-17473-1-git-send-email-den@openvz.org> <1422366699-17473-8-git-send-email-den@openvz.org> In-Reply-To: <1422366699-17473-8-git-send-email-den@openvz.org> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/7] block/raw-posix: set max_write_zeroes to INT_MAX for regular files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Kevin Wolf , Peter Lieven , Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi On 2015-01-27 at 08:51, Denis V. Lunev wrote: > fallocate() works fine and could handle properly with arbitrary size > requests. Maybe "could properly handle arbitrary size requests" (or "...arbitrarily sized requests")? > There is no sense to reduce the amount of space to fallocate. > The bigger is the size, the better is the performance as the amount of > journal updates is reduced. True for fallocate(). But is it true for xfs_write_zeroes(), too? I guess so, but I don't know. If it does, the patch looks good to me. Max > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > CC: Stefan Hajnoczi > CC: Peter Lieven > CC: Fam Zheng > --- > block/raw-posix.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+)