From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGAmF-0000y1-SU for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:22:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGAmA-00087C-Rf for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:22:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGAmA-00086x-KI for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:22:10 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0RIM9kq000969 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 27 Jan 2015 13:22:09 -0500 Message-ID: <54C7D750.1020602@redhat.com> Date: Tue, 27 Jan 2015 11:22:08 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422288204-29271-1-git-send-email-mreitz@redhat.com> <1422288204-29271-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1422288204-29271-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pH94kv9KEame5DRbU72Obbb0c1LVEF83A" Subject: Re: [Qemu-devel] [PATCH 01/50] blockdev: Allow creation of BDS trees without BB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , john@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pH94kv9KEame5DRbU72Obbb0c1LVEF83A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2015 09:02 AM, Max Reitz wrote: > If the "id" field is missing from the options given to blockdev-add, > just omit the BlockBackend and create the BlockDriverState tree alone. >=20 > Signed-off-by: Max Reitz > --- > blockdev.c | 38 +++++++++++++++++++++++++-------------= > tests/qemu-iotests/087 | 20 -------------------- > tests/qemu-iotests/087.out | 12 ------------ > 3 files changed, 25 insertions(+), 45 deletions(-) I'd feel more comfortable if this patch also touched qapi/block-core.json to mention the change in policy on BlockdevOptionsBase. Also, should 'node-name' be mandatory when omitting 'id'? But the idea makes sense. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --pH94kv9KEame5DRbU72Obbb0c1LVEF83A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUx9dQAAoJEKeha0olJ0NqNDAH/RKJL17e3IyIvmyrDLlxvs1r HrFZbB2EftM/eERNOQTgE5357e2EPLsBDvhiyIxSDCKoOhTWh6Y6XlNnXxctRbHV PE9R4lbJmFti0PmtjfjnKYgVlePdAibAkc91CByzAYvrYvJm1sSqOdX3PSsamLDd o7LJKGoIpCvxFon3esqtoVFNgA8UWrjR1MCffeUG9pqj/o4mkGl9eUjGMoWokR0f lZADRCY4BmiyLqVHCmit4qB0qQVK3Bv4jQRrHJtkCWKo4r8Ol/UnLB2yNDLWa/D1 Ko49Ten78rQ2xYTPdgA4t4FLaE93MDf/VKl4aufTxppweTJ52yaraU91H9LUI9I= =ljEw -----END PGP SIGNATURE----- --pH94kv9KEame5DRbU72Obbb0c1LVEF83A--