From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YGAqF-0005Y3-2D
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:26:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YGAqB-0001Tp-3O
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:26:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55339)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YGAqA-0001Tf-Sa
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:26:19 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0RIQIth026666
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 27 Jan 2015 13:26:18 -0500
Message-ID: <54C7D848.5090400@redhat.com>
Date: Tue, 27 Jan 2015 13:26:16 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1422288204-29271-1-git-send-email-mreitz@redhat.com>
	<1422288204-29271-2-git-send-email-mreitz@redhat.com>
	<54C7D750.1020602@redhat.com>
In-Reply-To: <54C7D750.1020602@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/50] blockdev: Allow creation of BDS
	trees without BB
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Jeff Cody <jcody@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, john@redhat.com

On 2015-01-27 at 13:22, Eric Blake wrote:
> On 01/26/2015 09:02 AM, Max Reitz wrote:
>> If the "id" field is missing from the options given to blockdev-add,
>> just omit the BlockBackend and create the BlockDriverState tree alone.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   blockdev.c                 | 38 +++++++++++++++++++++++++-------------
>>   tests/qemu-iotests/087     | 20 --------------------
>>   tests/qemu-iotests/087.out | 12 ------------
>>   3 files changed, 25 insertions(+), 45 deletions(-)
> I'd feel more comfortable if this patch also touched
> qapi/block-core.json to mention the change in policy on
> BlockdevOptionsBase.

Will do.

> Also, should 'node-name' be mandatory when
> omitting 'id'?

Seems good to me. Not specifying a node-name doesn't make a whole lot of 
sense, except for when you really badly want qemu to create useless 
structures in memory.

Max