From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGBCG-0005AL-T7 for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:49:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGBCD-0000xZ-IP for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:49:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGBCD-0000xT-9n for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:49:05 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0RIn3Cp001811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 27 Jan 2015 13:49:04 -0500 Message-ID: <54C7DD9E.3080103@redhat.com> Date: Tue, 27 Jan 2015 11:49:02 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422288204-29271-1-git-send-email-mreitz@redhat.com> <1422288204-29271-3-git-send-email-mreitz@redhat.com> In-Reply-To: <1422288204-29271-3-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="etsjtNXbx9XLPjvToKcOMtAmH58VWdkuN" Subject: Re: [Qemu-devel] [PATCH 02/50] iotests: Only create BB if necessary List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , john@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --etsjtNXbx9XLPjvToKcOMtAmH58VWdkuN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2015 09:02 AM, Max Reitz wrote: > Tests 071 and 081 test giving references in blockdev-add. It is not > necessary to create a BlockBackend here, so omit it. >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/071 | 50 ++++++++++++++++++++++++++++++++++++++= ++++---- > tests/qemu-iotests/071.out | 12 +++++++---- > tests/qemu-iotests/081 | 14 ++++++++++++- > tests/qemu-iotests/081.out | 5 +++-- > 4 files changed, 70 insertions(+), 11 deletions(-) >=20 Reviewed-by: Eric Blake but given my comments in 1/50, you'll want to also add a test somewhere (either there or here) that omitting both id and node-name gives an error= =2E --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --etsjtNXbx9XLPjvToKcOMtAmH58VWdkuN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUx92eAAoJEKeha0olJ0Nqt1IIAJjSgn8Y62QuEC5kwTEZzr1C wM6moqeGewdx4JkBQ96QncCtop1cKJ70W3IoJGAP4Z6mp746FNRlvOZzVb6iwb0Z EHD/PtWvTK7ZNV99DY7HJdE4OEqSvqjqtOUl1fXdSeIXORFjr6TzTbjmquwxIiz/ oTcyCDX9LwIjalPQPkggRGqDguvaLTBGSuK2RvEAuMJKhksbXxrKhZ3W0b8gBO6B xfvCyEzG9Vq0Uk7Iw+tRhIIkZWnFGITWrI6+uCTLaoaWGcSBd6TlkLPq979bkqyy Nu2NkfWJvayctf1zmaL8YqO7g3+61/879ebMva7AJTDS9ONRv8G9TyGD2EvlsaA= =XVd5 -----END PGP SIGNATURE----- --etsjtNXbx9XLPjvToKcOMtAmH58VWdkuN--