From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGCn0-0006i5-4q for qemu-devel@nongnu.org; Tue, 27 Jan 2015 15:31:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGCmw-00014K-RM for qemu-devel@nongnu.org; Tue, 27 Jan 2015 15:31:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGCmw-000145-Ji for qemu-devel@nongnu.org; Tue, 27 Jan 2015 15:31:06 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0RKV5ud031027 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 27 Jan 2015 15:31:05 -0500 Message-ID: <54C7F588.6020602@redhat.com> Date: Tue, 27 Jan 2015 13:31:04 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422387983-32153-1-git-send-email-mreitz@redhat.com> <1422387983-32153-12-git-send-email-mreitz@redhat.com> In-Reply-To: <1422387983-32153-12-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rPqSPenuInqT417sRP811OBoG4oH7LWR9" Subject: Re: [Qemu-devel] [PATCH RESEND 11/50] block: Move BlockAcctStats into BlockBackend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rPqSPenuInqT417sRP811OBoG4oH7LWR9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [replies to earlier patches in the other thread; moving the rest of my review here for the sake of improved cc] On 01/27/2015 12:45 PM, Max Reitz wrote: > As the comment above bdrv_get_stats() says, BlockAcctStats is something= > which belongs to the device instead of each BlockDriverState. This patc= h > therefore moves it into the BlockBackend. >=20 > Signed-off-by: Max Reitz > --- > block.c | 11 ----------- > block/block-backend.c | 5 ++++- > block/qapi.c | 20 ++++++++++++-------- > include/block/block.h | 2 -- > include/block/block_int.h | 3 --- > 5 files changed, 16 insertions(+), 25 deletions(-) >=20 Reviewed-by: Eric Blake (I spent some time hunting to ensure that 0-initialized stats make sense when there is no BB - libvirt returns -1 rather than 0 for some stats, but it's always a pain to remember which stats have the special treatment= ) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rPqSPenuInqT417sRP811OBoG4oH7LWR9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUx/WIAAoJEKeha0olJ0NqM70H/ic+yuGDh2xhCKJyvz2DCBa1 qF04Phc/7jB1aFuuC37BIPD1n0rRCcMd/N1EMEuabSZ7fQafDW5wegQZUvBY3b0c pkDOqO5RXObDvfFBlI2A6q9RN/8qbYCQSwP1MJaAzMutTscKqt4tbggJZJamp3H4 at4GWlXmtcvaL3h9zPuBtip6jk1JD1uI/aoZ5ORpcS6kbP9E3qxisJByIgDx2nJT /wv/unH8VUPlyYXVPciAvIhxDoSb0UdIOuOY/k0O+vX0To0zMvquq2jO2ojGE36j pS9LtuKUfAdw/eU1zD8gkbFSW5D24vojdvGH1/w0i17U0L2RcpGjzobAOWvwFRA= =wJcP -----END PGP SIGNATURE----- --rPqSPenuInqT417sRP811OBoG4oH7LWR9--