Re: [Qemu-devel] [PATCH RESEND 19/50] blockdev: Use BlockBackend for blockdev-backup TA

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

On 01/27/2015 12:45 PM, Max Reitz wrote:
> When preparing a blockdev-backup transaction, the BlockBackend should be
> used because there may be no medium associated to the BB (which would
> make bdrv_find() fail, whereas blk_by_name() does not).
> 
> This does not make a real difference because blockdev-backup will fail
> without a medium anyway; however, it will have an impact on the error
> returned ("device not found" vs. "no medium").
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  blockdev.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)

And no tests changed output as a result?  Might be worth adding a test
for the error message.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]