From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGEAc-0005YD-BM for qemu-devel@nongnu.org; Tue, 27 Jan 2015 16:59:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGEAU-0006i4-W2 for qemu-devel@nongnu.org; Tue, 27 Jan 2015 16:59:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGEAU-0006hw-NH for qemu-devel@nongnu.org; Tue, 27 Jan 2015 16:59:30 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0RLxTM3031100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 27 Jan 2015 16:59:29 -0500 Message-ID: <54C80A3F.6090308@redhat.com> Date: Tue, 27 Jan 2015 14:59:27 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422387983-32153-1-git-send-email-mreitz@redhat.com> <1422387983-32153-20-git-send-email-mreitz@redhat.com> In-Reply-To: <1422387983-32153-20-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2u1ESfLIBTqDqUstp4HxnNgAeaWMmTFOa" Subject: Re: [Qemu-devel] [PATCH RESEND 19/50] blockdev: Use BlockBackend for blockdev-backup TA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2u1ESfLIBTqDqUstp4HxnNgAeaWMmTFOa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/27/2015 12:45 PM, Max Reitz wrote: > When preparing a blockdev-backup transaction, the BlockBackend should b= e > used because there may be no medium associated to the BB (which would > make bdrv_find() fail, whereas blk_by_name() does not). >=20 > This does not make a real difference because blockdev-backup will fail > without a medium anyway; however, it will have an impact on the error > returned ("device not found" vs. "no medium"). >=20 > Signed-off-by: Max Reitz > --- > blockdev.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) And no tests changed output as a result? Might be worth adding a test for the error message. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2u1ESfLIBTqDqUstp4HxnNgAeaWMmTFOa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUyAo/AAoJEKeha0olJ0NqqlMH/0N3pybxS0rikf7TdFFRyLOY AAlkEJ4qr/faZuEK10r/Dql7ZvBsSgRQt6Ck7l2jw8LTZ/yg7vMnQpj1bW3ZbUpB 9fwvteeNmLQaHi719RezuPQRJI88pZGAHDeqz0SkqqaGsoPNHmF6WdoTgl6ychbd XGKM5E7OA3URAgPypoSroMX+1gMid2aP2TF6Sf0ahbr7kkdjudHcLGh7K9Pdi5q7 ZC984e+RRNOT3WI8HLVS746g67YW1Fe+MH0kpJ4Ip0x5nEl4Yrx4tzP7JuasDo8e U92MXvIda2xU0G2VrLikdw5YXSBuWia7y8+sfxf92cEuAzFLQWKdxWUdQOf4QX0= =7vid -----END PGP SIGNATURE----- --2u1ESfLIBTqDqUstp4HxnNgAeaWMmTFOa--