From: "Denis V. Lunev" <den@openvz.org>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>,
Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 7/7] block/raw-posix: set max_write_zeroes to INT_MAX for regular files
Date: Wed, 28 Jan 2015 09:39:28 +0300 [thread overview]
Message-ID: <54C88420.60202@openvz.org> (raw)
In-Reply-To: <54C7D354.2030003@redhat.com>
On 27/01/15 21:05, Max Reitz wrote:
> On 2015-01-27 at 08:51, Denis V. Lunev wrote:
>> fallocate() works fine and could handle properly with arbitrary size
>> requests.
>
> Maybe "could properly handle arbitrary size requests" (or
> "...arbitrarily sized requests")?
>
>> There is no sense to reduce the amount of space to fallocate.
>> The bigger is the size, the better is the performance as the amount of
>> journal updates is reduced.
>
> True for fallocate(). But is it true for xfs_write_zeroes(), too? I
> guess so, but I don't know.
>
> If it does, the patch looks good to me.
>
> Max
>
checked.
xfs_ioc_space (ioctl handler) calls exactly the same xfs_zero_file_space as
performed by xfs_file_fallocate on fallocate path.
I will reflect this in the description
Regards,
Den
next prev parent reply other threads:[~2015-01-28 6:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 13:51 [Qemu-devel] [PATCH v4 0/7] eliminate data write in bdrv_write_zeroes on Linux in raw-posix.c Denis V. Lunev
2015-01-27 13:51 ` [Qemu-devel] [PATCH 1/7] block/raw-posix: create translate_err helper to merge errno values Denis V. Lunev
2015-01-27 16:50 ` Max Reitz
2015-01-27 13:51 ` [Qemu-devel] [PATCH 2/7] block/raw-posix: create do_fallocate helper Denis V. Lunev
2015-01-27 16:57 ` Max Reitz
2015-01-27 13:51 ` [Qemu-devel] [PATCH 3/7] block/raw-posix: refactor handle_aiocb_write_zeroes a bit Denis V. Lunev
2015-01-27 17:13 ` Max Reitz
2015-01-27 13:51 ` [Qemu-devel] [PATCH 4/7] block: use fallocate(FALLOC_FL_ZERO_RANGE) in handle_aiocb_write_zeroes Denis V. Lunev
2015-01-27 17:30 ` Max Reitz
2015-01-27 13:51 ` [Qemu-devel] [PATCH 5/7] block: use fallocate(FALLOC_FL_PUNCH_HOLE) & fallocate(0) to write zeroes Denis V. Lunev
2015-01-27 17:48 ` Max Reitz
2015-01-27 13:51 ` [Qemu-devel] [PATCH 6/7] block/raw-posix: call plain fallocate in handle_aiocb_write_zeroes Denis V. Lunev
2015-01-27 17:57 ` Max Reitz
2015-01-27 18:19 ` Denis V. Lunev
2015-01-27 18:24 ` Max Reitz
2015-01-27 18:33 ` Denis V. Lunev
2015-01-27 13:51 ` [Qemu-devel] [PATCH 7/7] block/raw-posix: set max_write_zeroes to INT_MAX for regular files Denis V. Lunev
2015-01-27 18:05 ` Max Reitz
2015-01-27 18:11 ` Denis V. Lunev
2015-01-28 6:39 ` Denis V. Lunev [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-28 18:38 [Qemu-devel] [PATCH v5 0/7] eliminate data write in bdrv_write_zeroes on Linux in raw-posix.c Denis V. Lunev
2015-01-28 18:38 ` [Qemu-devel] [PATCH 7/7] block/raw-posix: set max_write_zeroes to INT_MAX for regular files Denis V. Lunev
2015-01-29 22:51 ` Max Reitz
2015-01-30 8:42 [Qemu-devel] [PATCH v6 0/7] eliminate data write in bdrv_write_zeroes on Linux in raw-posix.c Denis V. Lunev
2015-01-30 8:42 ` [Qemu-devel] [PATCH 7/7] block/raw-posix: set max_write_zeroes to INT_MAX for regular files Denis V. Lunev
2015-02-02 13:23 ` Kevin Wolf
2015-02-02 13:55 ` Peter Lieven
2015-02-02 14:04 ` Kevin Wolf
2015-02-02 14:12 ` Peter Lieven
2015-02-02 14:16 ` Kevin Wolf
2015-02-02 14:20 ` Peter Lieven
2015-02-02 14:38 ` Denis V. Lunev
2015-02-02 14:49 ` Kevin Wolf
2015-02-02 15:30 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C88420.60202@openvz.org \
--to=den@openvz.org \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).