* [Qemu-devel] [PATCH] scsi: Fix scsi_req_cancel_async for no aiocb req
@ 2015-01-27 9:16 Fam Zheng
2015-01-28 9:45 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Fam Zheng @ 2015-01-27 9:16 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini
scsi_req_cancel_complete is responsible for releasing the request, so we
shouldn't skip it in any case. This doesn't affect the only existing
caller, virtio-scsi, but is useful for other devices once they use it.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
hw/scsi/scsi-bus.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
index 9b740a3..db39ae0 100644
--- a/hw/scsi/scsi-bus.c
+++ b/hw/scsi/scsi-bus.c
@@ -1756,6 +1756,8 @@ void scsi_req_cancel_async(SCSIRequest *req, Notifier *notifier)
req->io_canceled = true;
if (req->aiocb) {
blk_aio_cancel_async(req->aiocb);
+ } else {
+ scsi_req_cancel_complete(req);
}
}
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] scsi: Fix scsi_req_cancel_async for no aiocb req
2015-01-27 9:16 [Qemu-devel] [PATCH] scsi: Fix scsi_req_cancel_async for no aiocb req Fam Zheng
@ 2015-01-28 9:45 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2015-01-28 9:45 UTC (permalink / raw)
To: Fam Zheng, qemu-devel
On 27/01/2015 10:16, Fam Zheng wrote:
> scsi_req_cancel_complete is responsible for releasing the request, so we
> shouldn't skip it in any case. This doesn't affect the only existing
> caller, virtio-scsi, but is useful for other devices once they use it.
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> hw/scsi/scsi-bus.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
> index 9b740a3..db39ae0 100644
> --- a/hw/scsi/scsi-bus.c
> +++ b/hw/scsi/scsi-bus.c
> @@ -1756,6 +1756,8 @@ void scsi_req_cancel_async(SCSIRequest *req, Notifier *notifier)
> req->io_canceled = true;
> if (req->aiocb) {
> blk_aio_cancel_async(req->aiocb);
> + } else {
> + scsi_req_cancel_complete(req);
> }
> }
>
>
Applied, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-28 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-27 9:16 [Qemu-devel] [PATCH] scsi: Fix scsi_req_cancel_async for no aiocb req Fam Zheng
2015-01-28 9:45 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).