From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGPGJ-0003hi-CR for qemu-devel@nongnu.org; Wed, 28 Jan 2015 04:50:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGPGE-0006R4-D0 for qemu-devel@nongnu.org; Wed, 28 Jan 2015 04:50:15 -0500 Received: from mail-qg0-x236.google.com ([2607:f8b0:400d:c04::236]:40948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGPGE-0006Qx-9f for qemu-devel@nongnu.org; Wed, 28 Jan 2015 04:50:10 -0500 Received: by mail-qg0-f54.google.com with SMTP id q108so15894623qgd.13 for ; Wed, 28 Jan 2015 01:50:09 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54C8B0C8.3040809@redhat.com> Date: Wed, 28 Jan 2015 10:50:00 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1419353600-30519-2-git-send-email-pbonzini@redhat.com> <20150102140658.GL10823@stefanha-thinkpad.redhat.com> <54A6C53E.3050905@redhat.com> <54BCEA0F.8070707@redhat.com> In-Reply-To: <54BCEA0F.8070707@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] net: synchronize net_host_device_remove with host_net_remove_completion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, stefanha@redhat.com On 19/01/2015 12:27, Paolo Bonzini wrote: > > > On 02/01/2015 17:20, Paolo Bonzini wrote: >>>> >>>> The assert can be dropped completely since the code already has an >>>> equivalent assert: >>>> >>>> queues = qemu_find_net_clients_except(nc->name, ncs, >>>> NET_CLIENT_OPTIONS_KIND_NIC, >>>> MAX_QUEUE_NUM); >>>> assert(queues != 0); <-- fail if type == NET_CLIENT_OPTIONS_KIND_NIC >> I left it on purpose for documentation, but I'll send v2 next week that >> removes it. > > Actually it's not the same. If you have "-netdev user,id=e1000 -device > e1000,netdev=e1000" you will be able to call qemu_del_net_client on the > NIC, and it will _not_ fail if the assertion is removed. Ping? Paolo