From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGPVj-0007kR-Lh for qemu-devel@nongnu.org; Wed, 28 Jan 2015 05:06:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGPVf-0002wm-MB for qemu-devel@nongnu.org; Wed, 28 Jan 2015 05:06:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGPVf-0002wi-Ew for qemu-devel@nongnu.org; Wed, 28 Jan 2015 05:06:07 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SA66Kq026320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 28 Jan 2015 05:06:07 -0500 Message-ID: <54C8B48C.40609@redhat.com> Date: Wed, 28 Jan 2015 11:06:04 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1422439112-12336-1-git-send-email-armbru@redhat.com> In-Reply-To: <1422439112-12336-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] coverity: Improve and extend model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org On 28/01/2015 10:58, Markus Armbruster wrote: > I examined the differences between local scans with and without a > derived model file for GLib, to gauge what we're missing (the Coverity > Scan service we use can't do derived model files). Doesn't look bad, > but a few missed memory leaks caught my attention. I improved our > model file to catch them (PATCH 1+2). Topped off with PATCH 3 to > catch mixing up g_free() and free(). > > Markus Armbruster (3): > coverity: Improve model for GLib memory allocation > coverity: Model GLib string allocation partially > coverity: Model g_free() isn't necessarily free() > > scripts/coverity-model.c | 228 +++++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 193 insertions(+), 35 deletions(-) > Acked-by: Paolo Bonzini It's missing a patch to add a MAINTAINERS entry though! :) Paolo