From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGUJZ-00066B-Dx for qemu-devel@nongnu.org; Wed, 28 Jan 2015 10:14:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGUJY-0005iG-DH for qemu-devel@nongnu.org; Wed, 28 Jan 2015 10:13:57 -0500 Message-ID: <54C8FCAC.7070905@redhat.com> Date: Wed, 28 Jan 2015 08:13:48 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422456844-13043-1-git-send-email-armbru@redhat.com> In-Reply-To: <1422456844-13043-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9kuJEitwt3GSOOEjqeTdtAEdsRG7jLcrK" Subject: Re: [Qemu-devel] [PATCH 0/4] Pair g_malloc() with g_free(), not free() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9kuJEitwt3GSOOEjqeTdtAEdsRG7jLcrK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/28/2015 07:54 AM, Markus Armbruster wrote: > I'm routing these patches through qemu-trivial, even though some of > them touch actively maintained code, and could go through the > respective tree instead: >=20 > * PATCH 3 sPAPR (Alex) >=20 > * PATCH 4 USB (Gerd) >=20 > If you want me to reroute any of them, let me know. Reviewed-by: Eric Blake [for patches like these, sometimes I like to use git format-patch -U20 or whatever it takes to make the patch show full context of the allocation a few lines earlier that matches with the actual g_free fix, so that reviewers don't have to open the file themselves. It makes for larger emails, but potentially faster reviews. But it's not the end of the world to stick with the default 3-line context] >=20 > Markus Armbruster (4): > qemu-option: Replace pointless use of g_malloc0() by g_malloc() > qemu-option: Pair g_malloc() with g_free(), not free() > spapr_vio: Pair g_malloc() with g_free(), not free() > usb: Pair g_malloc() with g_free(), not free() >=20 > hw/ppc/spapr_vio.c | 2 +- > hw/usb/desc-msos.c | 2 +- > util/qemu-option.c | 8 ++++---- > 3 files changed, 6 insertions(+), 6 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9kuJEitwt3GSOOEjqeTdtAEdsRG7jLcrK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUyPysAAoJEKeha0olJ0Nqhu0H/04WUhv+2kESZ+d5Q5/ZloKC +nTXdbZ9jDBLDaDqtNnBZa6Q0ut8lDyE/QiG2qk1WjmROmuLDcujSojuIKCpj01F NV+wXGSRrECgFZtJ2M63yvgtuYcHH3eMfdSgT6ivnuaPYTlQKrT96p23djhwnlHI xz9caNfEvW7U+oYE2PGESiEn+KhUKKOwMvoqQj4ZyJ/kSk0ZhoI0nfp+chlxbQcx nmw49TOTEZigemsvDJIW0KSf4uX1P7RJrl68ZpL9ojIaLZ16RmAJbVNQOyL0QsEV wTBPxO2mrvXvVOl7A3idhUuIMFxkWm6lgZpTMfYTx1bGm9g900Il+DGOITu2jWw= =atiH -----END PGP SIGNATURE----- --9kuJEitwt3GSOOEjqeTdtAEdsRG7jLcrK--