qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Claudio Fontana <claudio.fontana@huawei.com>
To: "Peter Maydell" <peter.maydell@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>
Cc: Xiangyu Hu <libhu.so@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] FMULX should flushes operators to zero when FZ is set.
Date: Wed, 28 Jan 2015 17:12:21 +0100	[thread overview]
Message-ID: <54C90A65.4090909@huawei.com> (raw)
In-Reply-To: <CAFEAcA84cqR2WEG=15SAF9PfbMn_QO_6QQCbrX1j0Q2qoZ4dhA@mail.gmail.com>

Hi Peter,

On 28.01.2015 16:57, Peter Maydell wrote:
> On 28 January 2015 at 15:54, Alex Bennée <alex.bennee@linaro.org> wrote:
>> Do we have test cases that trip up here? It would be nice to include
>> them in our testing as the random nature of RISU has obviously failed to
>> trip up on this instruction.
> 
> Risu would probably catch this if we generated and ran test cases
> which set the FPSCR bits to something other than the default.
> (At least the 32-bit risugen lets you do this; I forget whether
> we wired up that bit in the 64-bit support code.)
> 
> -- PMM
> 

If nobody improved it from my implementation, the risugen script
will generate code which sets FPSR always unconditionally to 0,
while the FPCR is wired up with the user-provided "fpscr" option.
Not that there's any good reason behind it, probably both should be configurable..

Ciao,

Claudio

  parent reply	other threads:[~2015-01-28 16:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 14:51 [Qemu-devel] [PATCH] FMULX should flushes operators to zero when FZ is set Xiangyu Hu
2015-01-28 14:54 ` Peter Maydell
2015-01-28 15:42   ` Xiangyu Hu
2015-01-28 15:54 ` Alex Bennée
2015-01-28 15:57   ` Peter Maydell
2015-01-28 16:11     ` Xiangyu Hu
2015-01-28 16:12     ` Claudio Fontana [this message]
2015-01-28 16:25       ` Peter Maydell
2015-01-29 19:22     ` Peter Maydell
2015-02-03 13:44       ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C90A65.4090909@huawei.com \
    --to=claudio.fontana@huawei.com \
    --cc=alex.bennee@linaro.org \
    --cc=libhu.so@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).