From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGWlW-00056z-Sv for qemu-devel@nongnu.org; Wed, 28 Jan 2015 12:50:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGWlR-0006xK-VY for qemu-devel@nongnu.org; Wed, 28 Jan 2015 12:50:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGWlR-0006xG-N2 for qemu-devel@nongnu.org; Wed, 28 Jan 2015 12:50:53 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SHopdN011494 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 28 Jan 2015 12:50:52 -0500 Message-ID: <54C9217A.10907@redhat.com> Date: Wed, 28 Jan 2015 10:50:50 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422387983-32153-1-git-send-email-mreitz@redhat.com> <1422387983-32153-35-git-send-email-mreitz@redhat.com> In-Reply-To: <1422387983-32153-35-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RJ9tOP6jogF1LWpIoXf4XstgAgcBcgEeS" Subject: Re: [Qemu-devel] [PATCH RESEND 34/50] blockdev: Do not create BDS for empty drive List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RJ9tOP6jogF1LWpIoXf4XstgAgcBcgEeS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/27/2015 12:46 PM, Max Reitz wrote: > Do not use "rudimentary" BDSs for empty drives any longer (for > freshly created drives). >=20 > With this change, bdrv_close_all() has no effect on empty drives (whose= > media were not changed) any longer. This breaks some test outputs, fix > them. >=20 > After a follow-up patch, empty drives will generally use a NULL BDS, no= t > only the freshly created drives. >=20 > Signed-off-by: Max Reitz > --- > blockdev.c | 68 ++++++++++++++++++++++++++------------= -------- > tests/qemu-iotests/067.out | 44 ------------------------------ > tests/qemu-iotests/071.out | 2 -- > tests/qemu-iotests/081.out | 1 - > tests/qemu-iotests/087.out | 5 ---- > 5 files changed, 38 insertions(+), 82 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RJ9tOP6jogF1LWpIoXf4XstgAgcBcgEeS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUySF6AAoJEKeha0olJ0NqsJIH/0VHYMcXg4Dqn+1iBCSkZAzq kldyFRlUmJptxsbZxYLpR2UKDcD6aJ+PdtDA2hs9qjTfuI+MK92wrKhNsGhZe+wq dE6KhnMESXFtmfmyI/rfHupgfVoz3LXCWQ8PGE+nTfa8ELmouB3fVZNYB/rUEnzJ p+VpqSY3ozI9oRtcSXt2BtQnTnz3VkstdZyomR07isZG3avnBEMZFF+abbvJXth8 t77BoXnUNXmWFTPS6tEUgEYR64qDkjrEE/aF8EI5qzIMqcUYjzUvH2wUGGETIPuP 9HMMIeu31VhoZypGN7pGk6KYYKpYYlECKVVB6UbIIvJhnrPV+vqc289s7rR/0OQ= =host -----END PGP SIGNATURE----- --RJ9tOP6jogF1LWpIoXf4XstgAgcBcgEeS--