From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGYDZ-0001WM-FN for qemu-devel@nongnu.org; Wed, 28 Jan 2015 14:24:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGYDV-0001KB-EV for qemu-devel@nongnu.org; Wed, 28 Jan 2015 14:24:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGYDV-0001K6-5J for qemu-devel@nongnu.org; Wed, 28 Jan 2015 14:23:57 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SJNsaH011534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 28 Jan 2015 14:23:55 -0500 Message-ID: <54C93749.9010408@redhat.com> Date: Wed, 28 Jan 2015 12:23:53 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422387983-32153-1-git-send-email-mreitz@redhat.com> <1422387983-32153-36-git-send-email-mreitz@redhat.com> In-Reply-To: <1422387983-32153-36-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QN2J1BgfbbpAKGi8D4VgOgUPnK3qTbtES" Subject: Re: [Qemu-devel] [PATCH RESEND 35/50] blockdev: Pull out blockdev option extraction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QN2J1BgfbbpAKGi8D4VgOgUPnK3qTbtES Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/27/2015 12:46 PM, Max Reitz wrote: > Extract some of the blockdev option extraction code from blockdev_init(= ) > into an own function. This simplifies blockdev_init() and will allow s/an/its/ > reusing the code in a different function added in a follow-up patch. >=20 > Signed-off-by: Max Reitz > --- > blockdev.c | 201 +++++++++++++++++++++++++++++++++--------------------= -------- > 1 file changed, 108 insertions(+), 93 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QN2J1BgfbbpAKGi8D4VgOgUPnK3qTbtES Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUyTdJAAoJEKeha0olJ0NqI4wH/1rS96D4eJj04m7n4nZBa4/Q GdEEQwVeNIBEO9yF7Ih66AbkzIj6I813QEOCW+eSqnks2mB04EVTECqhDLOIgCEr mVCg/Yxpn79tSVtKPDrxJZ3U5jMj0LJfvAhRQFA0Azfhq6r3gPlZr6jL6gAzN3ML SvNrcTi4oGMaZuA8aXrWOROhj5fl14u+hs98f6KI33MPMs97jNj1UpPIVdOTlqyB /xv6uTq9+orh+LFSyveqWjJIoZO7YGspjEovx9S5S898V4TDXmlsrTsNyYxl9Ewh PuPNbCl2Gc7256qF7cELBixeDGEtbZaRR2g7aDR4BWQUUlh6TxfLdWGII4v0dao= =H0vu -----END PGP SIGNATURE----- --QN2J1BgfbbpAKGi8D4VgOgUPnK3qTbtES--