From: Don Slutz <dslutz@verizon.com>
To: Eric Blake <eblake@redhat.com>, Don Slutz <dslutz@verizon.com>,
qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION
Date: Wed, 28 Jan 2015 14:51:56 -0500 [thread overview]
Message-ID: <54C93DDC.2090203@terremark.com> (raw)
In-Reply-To: <54B00010.8030607@redhat.com>
Ping.
On 01/09/15 11:21, Eric Blake wrote:
> On 01/09/2015 08:17 AM, Don Slutz wrote:
>> This is the same way vl.c handles this.
>>
>> Signed-off-by: Don Slutz <dslutz@verizon.com>
>> ---
>> qemu-img.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
>>
>> diff --git a/qemu-img.c b/qemu-img.c
>> index 7876258..b6e9220 100644
>> --- a/qemu-img.c
>> +++ b/qemu-img.c
>> @@ -35,7 +35,7 @@
>> #include "block/qapi.h"
>> #include <getopt.h>
>>
>> -#define QEMU_IMG_VERSION "qemu-img version " QEMU_VERSION \
>> +#define QEMU_IMG_VERSION "qemu-img version " QEMU_VERSION QEMU_PKGVERSION \
>> ", Copyright (c) 2004-2008 Fabrice Bellard\n"
>>
>> typedef struct img_cmd_t {
>>
>
next prev parent reply other threads:[~2015-01-28 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 15:17 [Qemu-devel] [PATCH v2 0/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION (was qemu-img: Add --pkgversion common option) Don Slutz
2015-01-09 15:17 ` [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION Don Slutz
2015-01-09 16:21 ` Eric Blake
2015-01-28 19:51 ` Don Slutz [this message]
2015-02-02 13:55 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C93DDC.2090203@terremark.com \
--to=dslutz@verizon.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).