* [Qemu-devel] [PATCH v2 0/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION (was qemu-img: Add --pkgversion common option)
@ 2015-01-09 15:17 Don Slutz
2015-01-09 15:17 ` [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION Don Slutz
0 siblings, 1 reply; 5+ messages in thread
From: Don Slutz @ 2015-01-09 15:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Peter Maydell, Don Slutz, Stefan Hajnoczi
Changes v1 to v2:
Added a cover letter because subject changed.
Peter Maydell & Eric Blake
Switch to be consistent with both linux-user and the softmmu
emulators
---------------
Just a little backgound. --version was added to qemu-img:
5f6979cb (Jeff Cody 2014-04-28 14:37:18 -0400
I did this cahnge a long time before and just now getting
around to posting it:
85f9f5b2 (Don Slutz 2012-12-20 15:47:37 -0500
Don Slutz (1):
qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.8.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION
2015-01-09 15:17 [Qemu-devel] [PATCH v2 0/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION (was qemu-img: Add --pkgversion common option) Don Slutz
@ 2015-01-09 15:17 ` Don Slutz
2015-01-09 16:21 ` Eric Blake
2015-02-02 13:55 ` Kevin Wolf
0 siblings, 2 replies; 5+ messages in thread
From: Don Slutz @ 2015-01-09 15:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Peter Maydell, Don Slutz, Stefan Hajnoczi
This is the same way vl.c handles this.
Signed-off-by: Don Slutz <dslutz@verizon.com>
---
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index 7876258..b6e9220 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -35,7 +35,7 @@
#include "block/qapi.h"
#include <getopt.h>
-#define QEMU_IMG_VERSION "qemu-img version " QEMU_VERSION \
+#define QEMU_IMG_VERSION "qemu-img version " QEMU_VERSION QEMU_PKGVERSION \
", Copyright (c) 2004-2008 Fabrice Bellard\n"
typedef struct img_cmd_t {
--
1.8.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION
2015-01-09 15:17 ` [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION Don Slutz
@ 2015-01-09 16:21 ` Eric Blake
2015-01-28 19:51 ` Don Slutz
2015-02-02 13:55 ` Kevin Wolf
1 sibling, 1 reply; 5+ messages in thread
From: Eric Blake @ 2015-01-09 16:21 UTC (permalink / raw)
To: Don Slutz, qemu-devel; +Cc: Kevin Wolf, Peter Maydell, Stefan Hajnoczi
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On 01/09/2015 08:17 AM, Don Slutz wrote:
> This is the same way vl.c handles this.
>
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 7876258..b6e9220 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -35,7 +35,7 @@
> #include "block/qapi.h"
> #include <getopt.h>
>
> -#define QEMU_IMG_VERSION "qemu-img version " QEMU_VERSION \
> +#define QEMU_IMG_VERSION "qemu-img version " QEMU_VERSION QEMU_PKGVERSION \
> ", Copyright (c) 2004-2008 Fabrice Bellard\n"
>
> typedef struct img_cmd_t {
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION
2015-01-09 16:21 ` Eric Blake
@ 2015-01-28 19:51 ` Don Slutz
0 siblings, 0 replies; 5+ messages in thread
From: Don Slutz @ 2015-01-28 19:51 UTC (permalink / raw)
To: Eric Blake, Don Slutz, qemu-devel
Cc: Kevin Wolf, Peter Maydell, Stefan Hajnoczi
Ping.
On 01/09/15 11:21, Eric Blake wrote:
> On 01/09/2015 08:17 AM, Don Slutz wrote:
>> This is the same way vl.c handles this.
>>
>> Signed-off-by: Don Slutz <dslutz@verizon.com>
>> ---
>> qemu-img.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
>>
>> diff --git a/qemu-img.c b/qemu-img.c
>> index 7876258..b6e9220 100644
>> --- a/qemu-img.c
>> +++ b/qemu-img.c
>> @@ -35,7 +35,7 @@
>> #include "block/qapi.h"
>> #include <getopt.h>
>>
>> -#define QEMU_IMG_VERSION "qemu-img version " QEMU_VERSION \
>> +#define QEMU_IMG_VERSION "qemu-img version " QEMU_VERSION QEMU_PKGVERSION \
>> ", Copyright (c) 2004-2008 Fabrice Bellard\n"
>>
>> typedef struct img_cmd_t {
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION
2015-01-09 15:17 ` [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION Don Slutz
2015-01-09 16:21 ` Eric Blake
@ 2015-02-02 13:55 ` Kevin Wolf
1 sibling, 0 replies; 5+ messages in thread
From: Kevin Wolf @ 2015-02-02 13:55 UTC (permalink / raw)
To: Don Slutz; +Cc: Peter Maydell, qemu-devel, Stefan Hajnoczi
Am 09.01.2015 um 16:17 hat Don Slutz geschrieben:
> This is the same way vl.c handles this.
>
> Signed-off-by: Don Slutz <dslutz@verizon.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-02 13:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-09 15:17 [Qemu-devel] [PATCH v2 0/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION (was qemu-img: Add --pkgversion common option) Don Slutz
2015-01-09 15:17 ` [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION Don Slutz
2015-01-09 16:21 ` Eric Blake
2015-01-28 19:51 ` Don Slutz
2015-02-02 13:55 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).