From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60110)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YGYmB-0004b1-Ha
	for qemu-devel@nongnu.org; Wed, 28 Jan 2015 14:59:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YGYm6-000061-Jd
	for qemu-devel@nongnu.org; Wed, 28 Jan 2015 14:59:47 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59789)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YGYm6-00005X-4i
	for qemu-devel@nongnu.org; Wed, 28 Jan 2015 14:59:42 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SJxedp019644
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 28 Jan 2015 14:59:41 -0500
Message-ID: <54C93FA9.7040405@redhat.com>
Date: Wed, 28 Jan 2015 14:59:37 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1422387983-32153-1-git-send-email-mreitz@redhat.com>
	<1422387983-32153-39-git-send-email-mreitz@redhat.com>
	<54C93EEC.4010302@redhat.com>
In-Reply-To: <54C93EEC.4010302@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RESEND 38/50] blockdev: Add
	blockdev-open-tray
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Jeff Cody <jcody@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, John Snow <jsnow@redhat.com>

On 2015-01-28 at 14:56, Eric Blake wrote:
> On 01/27/2015 12:46 PM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   blockdev.c           | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>>   qapi/block-core.json | 21 +++++++++++++++++++++
>>   qmp-commands.hx      | 37 +++++++++++++++++++++++++++++++++++++
>>   3 files changed, 106 insertions(+)
>>
>> +Example (1):
>> +
> With only one example, the (1) doesn't add much.  Minor whether you
> leave it in or take it out.

I'll remove it.

Max

>> +-> { "execute": "blockdev-open-tray",
>> +     "arguments": { "device": "ide1-cd0" } }
>> +
>> +<- { "timestamp": { "seconds": 1418751016,
>> +                    "microseconds": 716996 },
>> +     "event": "DEVICE_TRAY_MOVED",
>> +     "data": { "device": "ide1-cd0",
>> +               "tray-open": true } }
>> +
>> +<- { "return": {} }
> Nice inclusion of the event alongside the return code!
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>