From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGa8y-0008D4-6l for qemu-devel@nongnu.org; Wed, 28 Jan 2015 16:27:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGa8x-0005zN-BA for qemu-devel@nongnu.org; Wed, 28 Jan 2015 16:27:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGa8x-0005zA-2I for qemu-devel@nongnu.org; Wed, 28 Jan 2015 16:27:23 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SLRMVU012822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 28 Jan 2015 16:27:22 -0500 Message-ID: <54C95439.60508@redhat.com> Date: Wed, 28 Jan 2015 14:27:21 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422387983-32153-1-git-send-email-mreitz@redhat.com> <1422387983-32153-50-git-send-email-mreitz@redhat.com> In-Reply-To: <1422387983-32153-50-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vPTaJMLvld01tp1cJvjbRdpUhJIse0DW8" Subject: Re: [Qemu-devel] [PATCH RESEND 49/50] iotests: More options for VM.add_drive() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vPTaJMLvld01tp1cJvjbRdpUhJIse0DW8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/27/2015 12:46 PM, Max Reitz wrote: > This patch allows specifying the interface to be used for the drive, an= d > makes specifying a path optional (if the path is None, the "file" optio= n > will be omitted, thus creating an empty drive). >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) >=20 > + > + if not path is None: > + options.append('file=3D%s' % path) Works, but it is more idiomatic to use 'if path is not None:', based on a grep of the source tree. With that minor switch, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vPTaJMLvld01tp1cJvjbRdpUhJIse0DW8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUyVQ5AAoJEKeha0olJ0Nqq3gH/A1pocHwscjwTlKzw5ECdpoU qdwuT1g0Y5l91LVMUFYoclzDxsiY2aBgtMcLUbX/A6l3Kowa8XA7OTs6mJC3lCZe y+tTGkMWs5Ca5Sv3T4ly9dUMYylXU4l5yc0plkpwgkc2aoxYTYXs6pMapqq8Njsv 8yZhB+jhRLPi8IoShB1MOS1bT9QiEhHz6mgptIHLw7CZu0sCfg+do8MzY+v912gh pzuQOukEbQamOHxdZcgwMvgQWODdaOV2GzYTFEqy4bBKQE6N1Hj6wCdKEU3j60xw PMsl/xNacs0f2sUg33lE+tgjnUGut5RtlTI5DRAbvN0xuj4AjJF4eIr1/i1X2R4= =AIuh -----END PGP SIGNATURE----- --vPTaJMLvld01tp1cJvjbRdpUhJIse0DW8--