From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGadE-000501-Fz for qemu-devel@nongnu.org; Wed, 28 Jan 2015 16:58:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGad9-0002i3-IS for qemu-devel@nongnu.org; Wed, 28 Jan 2015 16:58:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGad9-0002hl-9n for qemu-devel@nongnu.org; Wed, 28 Jan 2015 16:58:35 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SLwXIT026497 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 28 Jan 2015 16:58:34 -0500 Message-ID: <54C95B88.8030009@redhat.com> Date: Wed, 28 Jan 2015 14:58:32 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422387983-32153-1-git-send-email-mreitz@redhat.com> <1422387983-32153-50-git-send-email-mreitz@redhat.com> <54C95439.60508@redhat.com> <54C9546B.9060203@redhat.com> In-Reply-To: <54C9546B.9060203@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KrR6m1uqu0VQ0o0mwfr1nslbwJts1vvjD" Subject: Re: [Qemu-devel] [PATCH RESEND 49/50] iotests: More options for VM.add_drive() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KrR6m1uqu0VQ0o0mwfr1nslbwJts1vvjD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/28/2015 02:28 PM, Max Reitz wrote: > On 2015-01-28 at 16:27, Eric Blake wrote: >> On 01/27/2015 12:46 PM, Max Reitz wrote: >>> This patch allows specifying the interface to be used for the drive, = and >>> makes specifying a path optional (if the path is None, the "file" opt= ion >>> will be omitted, thus creating an empty drive). >>> >>> Signed-off-by: Max Reitz >>> --- >>> tests/qemu-iotests/iotests.py | 9 ++++++--- >>> 1 file changed, 6 insertions(+), 3 deletions(-) >>> >>> + >>> + if not path is None: >>> + options.append('file=3D%s' % path) >> Works, but it is more idiomatic to use 'if path is not None:', based o= n >> a grep of the source tree. >=20 > Did I ever mention I don't know Python very well? The feeling is mutual. So it's the blind leading the blind :) >=20 > That sounds a lot better, will do, thanks. >=20 >> With that minor switch, >> Reviewed-by: Eric Blake >=20 > On to the last patch! :-) >=20 > Max >=20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KrR6m1uqu0VQ0o0mwfr1nslbwJts1vvjD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUyVuIAAoJEKeha0olJ0NquCgH/0tL3wKXltYqA/tdUishz0Il IBnbUDUFP2n+fRO5/L2hvI6veswoxHhjNtD9qzXJwavX8BbHCCsB8H3s1sUJR6n+ +ubMr/F1VCqOtp091BzZ87hFYp4chRKSidgrL2WSCJ+88/KiD7H2jD/ZDhyDmzuM y9tNXLFuccOf7Dv6P+cZzz1SryrIM5PsRo4uCL3kq0cC2tBp5BDHjgDPeGn6gl51 iBkkj9xGa/GLwadfbyoqmmvC5IEAa+5p/kLKXkh3yWEkG0BJ2EvRLD2FiJ57G0V4 6eEB6eAT1U9+rg6JS16VQZXIfE3UIoNKP9E97PZKdUUZjqAqx0e+WNWFtkvYpjk= =5QuK -----END PGP SIGNATURE----- --KrR6m1uqu0VQ0o0mwfr1nslbwJts1vvjD--