From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YGagp-0000DF-39
	for qemu-devel@nongnu.org; Wed, 28 Jan 2015 17:02:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YGagg-0004gO-L0
	for qemu-devel@nongnu.org; Wed, 28 Jan 2015 17:02:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45407)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YGagg-0004ec-7A
	for qemu-devel@nongnu.org; Wed, 28 Jan 2015 17:02:14 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SM2CkB028151
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 28 Jan 2015 17:02:13 -0500
Message-ID: <54C95C62.3000700@redhat.com>
Date: Wed, 28 Jan 2015 17:02:10 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1422387983-32153-1-git-send-email-mreitz@redhat.com>
	<1422387983-32153-51-git-send-email-mreitz@redhat.com>
	<54C95B5E.9090604@redhat.com>
In-Reply-To: <54C95B5E.9090604@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RESEND 50/50] iotests: Add test for
 change-related QMP commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Jeff Cody <jcody@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, John Snow <jsnow@redhat.com>

On 2015-01-28 at 16:57, Eric Blake wrote:
> On 01/27/2015 12:46 PM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   tests/qemu-iotests/118     | 649 +++++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/118.out |   5 +
>>   tests/qemu-iotests/group   |   1 +
>>   3 files changed, 655 insertions(+)
>>   create mode 100755 tests/qemu-iotests/118
>>   create mode 100644 tests/qemu-iotests/118.out
>>
> Looks like lots of useful tests and good coverage, including things like
> no-op open of an already open tray.  I didn't spot any obvious flaws
> (but my python is weak), or think of any obvious missing tests, so feel
> free to add:
>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thank you very much for reviewing this series! I really did not think 
someone would jump on this so fast. :-)

Max