From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGcsx-00065i-4E for qemu-devel@nongnu.org; Wed, 28 Jan 2015 19:23:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGcsv-00057t-TN for qemu-devel@nongnu.org; Wed, 28 Jan 2015 19:23:03 -0500 Message-ID: <54C97D5D.5070105@huawei.com> Date: Thu, 29 Jan 2015 08:22:53 +0800 From: Gonglei MIME-Version: 1.0 References: <1422456844-13043-1-git-send-email-armbru@redhat.com> <1422456844-13043-5-git-send-email-armbru@redhat.com> In-Reply-To: <1422456844-13043-5-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] usb: Pair g_malloc() with g_free(), not free() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On 2015/1/28 22:54, Markus Armbruster wrote: > Spotted by Coverity with preview checker ALLOC_FREE_MISMATCH enabled > and my "coverity: Model g_free() isn't necessarily free()" model patch > applied. > > Signed-off-by: Markus Armbruster > --- > hw/usb/desc-msos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/usb/desc-msos.c b/hw/usb/desc-msos.c > index 334d1ae..32c3600 100644 > --- a/hw/usb/desc-msos.c > +++ b/hw/usb/desc-msos.c > @@ -231,7 +231,7 @@ int usb_desc_msos(const USBDesc *desc, USBPacket *p, > length = len; > } > memcpy(dest, buf, length); > - free(buf); > + g_free(buf); > > p->actual_length = length; > return 0; This patch had been added Gerd's usb queue :) http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01998.html Regards, -Gonglei