From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGpbH-0007uq-BH for qemu-devel@nongnu.org; Thu, 29 Jan 2015 08:57:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGpbC-0001ue-EH for qemu-devel@nongnu.org; Thu, 29 Jan 2015 08:57:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGpbC-0001tI-5j for qemu-devel@nongnu.org; Thu, 29 Jan 2015 08:57:34 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0TDvW42006609 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 29 Jan 2015 08:57:33 -0500 Message-ID: <54CA3C4B.1060103@redhat.com> Date: Thu, 29 Jan 2015 06:57:31 -0700 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FpXuKq3KG4CoeP1DHelM4Wb2wf4h5uVTv" Subject: Re: [Qemu-devel] [PATCHv3 1/2] vl.c: Fix error messages when parsing maxmem parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Krempa , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FpXuKq3KG4CoeP1DHelM4Wb2wf4h5uVTv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/29/2015 06:48 AM, Peter Krempa wrote: > Produce more human readable error messages and fix few spelling > mistakes. >=20 > Also remove a redundant check for the max memory size. >=20 > Signed-off-by: Peter Krempa > --- >=20 > Notes: > Version 3: > - forgot a word in one of the error messages > =20 > Version 2: > - fixed spacing in error message > - changed control flow to allow maxmem =3D=3D ram_size in case slot= s =3D=3D 0 >=20 > vl.c | 34 ++++++++++++++++------------------ > 1 file changed, 16 insertions(+), 18 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FpXuKq3KG4CoeP1DHelM4Wb2wf4h5uVTv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUyjxLAAoJEKeha0olJ0NqtuYH/2oBRjM9R0EJlzmChjyf63SM RyDW7SdrLhwCGjyIajypjmOBN/euNUZ+7yQjqX4aBpss39035fPHrImmQSoHd1Zm 58+YD2+fcOn278jAapIL+6KJxJGm0tdvLqq9UZYeuweEKRE6BEwPL3lUk2o1hc0k Ex7E5aSptjuF3FOKSPfygrJXTiEZAYd0vAN96j1/0O1fJCjJDpWGyOj0uoTibHLJ iDao0vXn5r40vYCevTP75T8oypaVBditOTKJsPViQU1ww6HC4dDgm8c58l0dcCEj YEOCg1Ltxpv0KoP96x9ZDzqoDzu+Bsm52MubsQ58BKClWlfWZoPhMGeyAJrB5nk= =OyyL -----END PGP SIGNATURE----- --FpXuKq3KG4CoeP1DHelM4Wb2wf4h5uVTv--