qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
	qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, liang.z.li@intel.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [RFC 0/1] Incoming migration vs early monitor commands
Date: Thu, 29 Jan 2015 08:25:36 -0700	[thread overview]
Message-ID: <54CA50F0.9050100@redhat.com> (raw)
In-Reply-To: <1422543997-22808-1-git-send-email-dgilbert@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]

On 01/29/2015 08:06 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> The attached patch allows you to execute QMP commands from the command
> line prior to -incoming or loadvm.
> 
> I've hit a few cases where we need to pass some state to an incoming
> migration, either:
>   1) Before it starts processing data
>     e.g. Liang Li's compression patches that have a parameter for the
>     number of decompression threads
> 
>   2) Before the socket is set up
>     so we can influence the connection made; e.g. specify we need to
>     have a return path for postcopy, or potentially open multiple connections
> 
> For tcp migration you can use the monitor for (1) prior to the accept;
> but it's no use for exec or fd.
> 
> I'd previously suggested adding option parsing to the -incoming URI;

That may still be feasible; we have QemuOpts for that purpose.

> but
> then I realised just being able to execute arbitrary QMP commands might
> be simpler, and we get reuse of all the migrate capability/parameter
> stuff for free, and maybe the arbitrary QMP commands are useful for
> something else.

It feels like command-line QMP would be write-only - there's no sane way
to issue query commands and react to what was queried.  The full power
of QMP is made possible with a bidirectional path, but the command line
is not bidirectional.  This hack may have uses, but I'm not sure it is
my first choice for any situation.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  parent reply	other threads:[~2015-01-29 15:25 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 15:06 [Qemu-devel] [RFC 0/1] Incoming migration vs early monitor commands Dr. David Alan Gilbert (git)
2015-01-29 15:06 ` [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line Dr. David Alan Gilbert (git)
2015-01-29 15:15   ` Daniel P. Berrange
2015-01-29 15:21     ` Eric Blake
2015-01-29 15:54       ` Dr. David Alan Gilbert
2015-01-29 16:01         ` Eric Blake
2015-01-29 16:28           ` Dr. David Alan Gilbert
2015-01-29 17:45             ` Eric Blake
2015-01-29 20:21               ` Dr. David Alan Gilbert
2015-01-29 20:48                 ` Eric Blake
2015-01-30  9:38                   ` Dr. David Alan Gilbert
2015-01-30  9:50                     ` Paolo Bonzini
2015-01-30  9:56                       ` Dr. David Alan Gilbert
2015-02-03 10:12                       ` Amit Shah
2015-02-03 11:02                         ` Paolo Bonzini
2015-01-30  9:50                     ` Daniel P. Berrange
2015-01-30  8:34                 ` Markus Armbruster
2015-01-30  9:20                   ` Dr. David Alan Gilbert
2015-01-30  9:43                     ` Markus Armbruster
2015-01-30  8:35       ` Markus Armbruster
2015-01-29 15:22     ` Dr. David Alan Gilbert
2015-01-29 15:31       ` Daniel P. Berrange
2015-01-29 15:46         ` Dr. David Alan Gilbert
2015-01-29 15:50           ` Eric Blake
2015-01-29 15:56             ` Dr. David Alan Gilbert
2015-01-29 15:58           ` Daniel P. Berrange
2015-01-30  9:52       ` Paolo Bonzini
2015-01-30 10:02         ` Dr. David Alan Gilbert
2015-01-30 10:27           ` Paolo Bonzini
2015-01-29 15:25 ` Eric Blake [this message]
2015-01-29 23:08 ` [Qemu-devel] [RFC 0/1] Incoming migration vs early monitor commands Paolo Bonzini
2015-01-30  9:42   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CA50F0.9050100@redhat.com \
    --to=eblake@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=liang.z.li@intel.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).