From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGsfC-0002lf-K8 for qemu-devel@nongnu.org; Thu, 29 Jan 2015 12:13:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGsf5-0000qb-0Q for qemu-devel@nongnu.org; Thu, 29 Jan 2015 12:13:54 -0500 Received: from cantor2.suse.de ([195.135.220.15]:34763 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGsf4-0000qN-QE for qemu-devel@nongnu.org; Thu, 29 Jan 2015 12:13:46 -0500 Message-ID: <54CA6A49.2040408@suse.de> Date: Thu, 29 Jan 2015 18:13:45 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1422543520-8604-1-git-send-email-armbru@redhat.com> In-Reply-To: <1422543520-8604-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 0/1] qtest: Generic PCI device test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mst@redhat.com Hi Markus, Again thanks for digging into this. Am 29.01.2015 um 15:58 schrieb Markus Armbruster: > This test does everything a number of existing tests currently do: >=20 > ac97-test.c e1000-test.c es1370-test.c eepro100-test.c > ne2000-test.c nvme-test.c pcnet-test.c rtl8139-test.c > tpci200-test.c virtio-balloon-test.c virtio-rng-test.c > vmxnet3-test.c >=20 > They are all marked "TODO: Replace with functional tests". Options >=20 > * Delete them now, undelete when we add functional tests >=20 > * Keep them, blacklist the devices in pci-devs-test.c >=20 > * Live with the duplicated testing >=20 > Andreas, I guess you got an opinion here. My preference would be to not remove device files. "Functional tests" refers to doing real device-specific MMIO or PIO, and the intent of contributing such stubs, beyond the basic -device init/realize testing, was lowering the hurdle so that maintainers can require bugfixers to contribute a matching test case where applicable. > There's overlap with a few others: >=20 > i82801b11-test.c usb-hcd-ehci-test.c usb-hcd-ohci-test.c > usb-hcd-xhci-test.c virtio-blk-test.c virtio-net-test.c > virtio-scsi-test.c virtio-serial-test.c >=20 > Options: >=20 > * Blacklist the devices in pci-devs-test.c >=20 > * Live with the duplicated testing >=20 > Andreas? Not having reviewed the respective test code yet, I would suggest to keep generic tests in pci-devs-test.c and to rather drop generic tests from device-specific files (de-duplication). While I haven't benchmarked it, I assume that the bigger contributor to qtest runtime is the overhead of spawning qemu-system-* processes rather than running multiple tests per process. So living with duplication may be a convenience option. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)