From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGzgv-00020H-Uo for qemu-devel@nongnu.org; Thu, 29 Jan 2015 19:44:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGzgp-00089w-4Y for qemu-devel@nongnu.org; Thu, 29 Jan 2015 19:44:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGzgo-00089m-Ti for qemu-devel@nongnu.org; Thu, 29 Jan 2015 19:44:03 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0U0i1Vu015444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 29 Jan 2015 19:44:01 -0500 Message-ID: <54CAD3D0.7040502@redhat.com> Date: Thu, 29 Jan 2015 19:44:00 -0500 From: John Snow MIME-Version: 1.0 References: <1418780167-16231-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1418780167-16231-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, mst@redhat.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com Post-holiday bump that this is sitting out there, awaiting love. If this gets merged, we should be able to enable Q35 migration soon,=20 which would be nice. --js On 12/16/2014 08:35 PM, John Snow wrote: > This series was written mostly by Paolo Bonzini to do two things: > > 1. Unify the restart callbacks for ISA, AHCI and BMDMA > 2. Ensure we can restart a command after migration > > Many of the early patches only make much sense considering the > end-goal of eliminating BMDMA specific restart code to be shared > with ISA and AHCI codepaths. > > Migration for halted commands is fixed for ISA, PCI and AHCI. > As a consequence, operations halted via rerror=3Dstop or werror=3Dstop > should be able to be successfully migrated and resumed when using > ISA, PCI, or AHCI. > > This series includes tests for ISA and PCI/BMDMA, but does not > yet include tests for AHCI, which require some more qtest work > to be upstreamed first. Regardless, the AHCI tests have been > written and can be observed at: > https://github.com/jnsnow/qemu/commits/ahci-devel-latest > > See "ahci: add migrate dma test" and "ahci-test: add flush migrate test= " > for the WIP versions of the AHCI test that I used to exercise this > patchset. > > John Snow (3): > ahci: Migrate IDEStatus > ahci: Recompute cur_cmd on migrate post load > qtest/ide: Test flush / retry for ISA and PCI > > Paolo Bonzini (14): > ide: start extracting ide_restart_dma out of bmdma_restart_dma > ide: prepare to move restart to common code > ide: introduce ide_register_restart_cb > ide: do not use BMDMA in restart callback > ide: pass IDEBus to the restart_cb > ide: move restart callback to common code > ide: remove restart_cb callback > ide: replace set_unit callback with more IDEBus state > ide: place initial state of the current request to IDEBus > ide: migrate initial request state via IDEBus > ide: commonize io_buffer_index initialization > ide: make more functions static > ide: support PIO restart for the ISA controller > ahci: add support for restarting non-queued commands > > hw/ide/ahci.c | 37 +++++++++--------- > hw/ide/atapi.c | 3 +- > hw/ide/cmd646.c | 3 +- > hw/ide/core.c | 109 +++++++++++++++++++++++++++++++++++++++++++++= ++------- > hw/ide/internal.h | 16 +++++--- > hw/ide/isa.c | 3 +- > hw/ide/macio.c | 6 --- > hw/ide/pci.c | 98 ++++++++-------------------------------------= --- > hw/ide/pci.h | 12 +++--- > hw/ide/piix.c | 3 +- > hw/ide/via.c | 3 +- > tests/ide-test.c | 20 +++++++--- > 12 files changed, 165 insertions(+), 148 deletions(-) > --=20 =97js