From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH4MK-0001FY-1d for qemu-devel@nongnu.org; Fri, 30 Jan 2015 00:43:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YH4MG-0005y7-Q9 for qemu-devel@nongnu.org; Fri, 30 Jan 2015 00:43:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48352) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH4MG-0005y2-IA for qemu-devel@nongnu.org; Fri, 30 Jan 2015 00:43:08 -0500 Message-ID: <54CB19DD.6030806@redhat.com> Date: Fri, 30 Jan 2015 13:42:53 +0800 From: Jason Wang MIME-Version: 1.0 References: <1422536379-18116-1-git-send-email-sebastian.huber@embedded-brains.de> In-Reply-To: <1422536379-18116-1-git-send-email-sebastian.huber@embedded-brains.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] net: cadence_gem: Set initial MAC address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sebastian Huber , qemu-devel@nongnu.org Cc: peter.crosthwaite@xilinx.com On 01/29/2015 08:59 PM, Sebastian Huber wrote: > Set initial MAC address to the one specified by the command line. > > Signed-off-by: Sebastian Huber > --- > hw/net/cadence_gem.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c > index de26609..a1aa91b 100644 > --- a/hw/net/cadence_gem.c > +++ b/hw/net/cadence_gem.c > @@ -1005,6 +1005,7 @@ static void gem_reset(DeviceState *d) > { > int i; > GemState *s = GEM(d); > + const uint8_t *a; > > DB_PRINT("\n"); > > @@ -1023,6 +1024,11 @@ static void gem_reset(DeviceState *d) > s->regs[GEM_DESCONF5] = 0x002f2145; > s->regs[GEM_DESCONF6] = 0x00000200; > > + /* Set MAC address */ > + a = &s->conf.macaddr.a[0]; > + s->regs[GEM_SPADDR1LO] = a[0] | (a[1] << 8) | (a[2] << 16) | (a[3] << 24); > + s->regs[GEM_SPADDR1HI] = a[4] | (a[5] << 8); > + > for (i = 0; i < 4; i++) { > s->sar_active[i] = false; > } > @@ -1245,7 +1251,6 @@ static int gem_init(SysBusDevice *sbd) > sysbus_init_mmio(sbd, &s->iomem); > sysbus_init_irq(sbd, &s->irq); > qemu_macaddr_default_if_unset(&s->conf.macaddr); > - This seems unnecessary. > s->nic = qemu_new_nic(&net_gem_info, &s->conf, > object_get_typename(OBJECT(dev)), dev->id, s); > Reviewed-by: Jason Wang