From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH8Fx-0003Vn-GX for qemu-devel@nongnu.org; Fri, 30 Jan 2015 04:52:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YH8Fq-0007uy-Mu for qemu-devel@nongnu.org; Fri, 30 Jan 2015 04:52:53 -0500 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:53044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH8Fq-0007ud-Ge for qemu-devel@nongnu.org; Fri, 30 Jan 2015 04:52:46 -0500 Received: by mail-wi0-f169.google.com with SMTP id h11so1774609wiw.0 for ; Fri, 30 Jan 2015 01:52:45 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54CB5469.80806@redhat.com> Date: Fri, 30 Jan 2015 10:52:41 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1422543997-22808-1-git-send-email-dgilbert@redhat.com> <1422543997-22808-2-git-send-email-dgilbert@redhat.com> <20150129151527.GE1102@redhat.com> <20150129152255.GC2391@work-vm> In-Reply-To: <20150129152255.GC2391@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , "Daniel P. Berrange" Cc: amit.shah@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, quintela@redhat.com On 29/01/2015 16:22, Dr. David Alan Gilbert wrote: > I'm a bit worried about whether starting an incoming migrate afterwards is > different in any subtle way. I can see there are a handful of devices that > have 'runstate_check(RUN_STATE_INMIGRATE)' calls in, and thus I'm not sure > that starting a paused VM and then flipping to RUN_STATE_INMIGRATE would > be quite the same. Ouch, you're right. Especially BDRV_O_INCOMING is scary. Paolo