From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH8o1-0003bZ-S3 for qemu-devel@nongnu.org; Fri, 30 Jan 2015 05:28:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YH8ny-0003HD-LF for qemu-devel@nongnu.org; Fri, 30 Jan 2015 05:28:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH8ny-0003H6-Ed for qemu-devel@nongnu.org; Fri, 30 Jan 2015 05:28:02 -0500 Message-ID: <54CB5CAC.10806@redhat.com> Date: Fri, 30 Jan 2015 11:27:56 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1422543997-22808-1-git-send-email-dgilbert@redhat.com> <1422543997-22808-2-git-send-email-dgilbert@redhat.com> <20150129151527.GE1102@redhat.com> <20150129152255.GC2391@work-vm> <54CB5469.80806@redhat.com> <20150130100212.GF2370@work-vm> In-Reply-To: <20150130100212.GF2370@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: amit.shah@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, quintela@redhat.com On 30/01/2015 11:02, Dr. David Alan Gilbert wrote: > Yes; I've not got a clue what it's effect is, but given it's glued into > the block code I'm sure that breaking it will be subtle and nasty. I'm > also reasonably sure it's probably going to do something different in the loadvm > case which is probably unintended. It avoids metadata writes that would be concurrent with the source's. loadvm is okay because it doesn't have a concurrently running source, but it doesn't hurt either. Paolo