From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH9hi-0006tk-Ks for qemu-devel@nongnu.org; Fri, 30 Jan 2015 06:25:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YH9hf-0004aR-6b for qemu-devel@nongnu.org; Fri, 30 Jan 2015 06:25:38 -0500 Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]:53950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH9he-0004aG-TE for qemu-devel@nongnu.org; Fri, 30 Jan 2015 06:25:35 -0500 Received: by mail-we0-f179.google.com with SMTP id q59so26556465wes.10 for ; Fri, 30 Jan 2015 03:25:34 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54CB6A2A.5030202@redhat.com> Date: Fri, 30 Jan 2015 12:25:30 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150122085127.5276.53895.stgit@PASHA-ISP.def.inno> <28048.5671981753$1422445570@news.gmane.org> <54CA09AD.2080605@redhat.com> In-Reply-To: <54CA09AD.2080605@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH v8 00/21] Deterministic replay core List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, alex.bennee@linaro.org, afaerber@suse.de, fred.konrad@greensocs.com On 29/01/2015 11:21, Paolo Bonzini wrote: > > > On 28/01/2015 12:45, Pavel Dovgaluk wrote: >> Ping? > > Reviewed 13 patches out of 21. Made some comments, but overall I'm > really pleased. Thanks for persisting! > > Will continue tomorrow. The second part has a few more problems: 1) some simple and stylistic (patch 15, 19-21) 2) the invasive changes in patches 16-18 are, well, invasive. Lacking a design and example document it is hard to review them. The block maintainers, also, probably have better ideas of what to do. 3) A design document is also needed for checkpoints (patch 14) Paolo