qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Cc: qemu devel list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] address order of virtio-mmio devices
Date: Fri, 30 Jan 2015 12:38:30 +0100	[thread overview]
Message-ID: <54CB6D36.9070305@redhat.com> (raw)
In-Reply-To: <20150130104833.GC27572@redhat.com>

On 01/30/15 11:48, Daniel P. Berrange wrote:
> On Fri, Jan 30, 2015 at 10:29:46AM +0000, Peter Maydell wrote:
>> On 30 January 2015 at 09:54, Daniel P. Berrange <berrange@redhat.com> wrote:
>>> While it is clear there is no solution that works correctly with all
>>> kernels, I hate to think that we're going to stick with an ordering
>>> that is clearly wrong for modern kernels, forever going forward. The
>>> aarch64 world is only just starting out, so on balance I think we
>>> should optimize for the future rather than the past, since that gives
>>> right behaviour for orders of magnitude more people in the long term.
>>
>> Yeah, I agree it's awkward. But I hate breaking people's
>> working setups, and we have no guarantee the kernel won't
>> change again in the future.
>>
>> You could try asking the kernel folk to revert that patch on
>> the basis that it breaks things...
> 
> Might be worth a shot - the patch is only a month old. Or at least do a
> followup patch to put the ordering back the way it was, rather than plain
> revert

Please note that (as far as I understand) the patch that I referenced is
indeed very new, it's not part of v3.18, but the reversal can easily be
seen with v3.18. In other words, the kernel patch I referenced
introduces no functional change, it just reorganizes stuff in the kernel
(AIUI), with the benefit of killing a superfluous field.

The reason I referenced it because its *commit message* gives good
background. If we really wanted to find the kernel change that reversed
the traversal, we'd have to talk to Grant and/or bisect the kernel.

Thanks
Laszlo

> Long term though it will be much better of AArch64 would just do PCI
> instead of MMIO bus. Then we have proper device addressing which we
> can control in a predictable manner that will be stable across hotplug
> and unplug and migration.  I hear there's work on PCI for AArch64 but
> is there a near term ETA yet ?
> 
> Regards,
> Daniel
> 

  parent reply	other threads:[~2015-01-30 11:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 17:25 [Qemu-devel] address order of virtio-mmio devices Laszlo Ersek
2015-01-29 17:59 ` Paolo Bonzini
2015-01-29 18:15 ` Peter Maydell
2015-01-29 18:29   ` Laszlo Ersek
2015-01-29 19:01     ` Peter Maydell
2015-01-29 19:12       ` Laszlo Ersek
2015-01-29 19:47         ` Laszlo Ersek
2015-01-29 20:05           ` Peter Maydell
2015-01-30  9:54             ` Daniel P. Berrange
2015-01-30 10:16               ` Laszlo Ersek
2015-01-30 10:29               ` Peter Maydell
2015-01-30 10:48                 ` Daniel P. Berrange
2015-01-30 10:54                   ` Peter Maydell
2015-01-30 11:32                     ` Peter Maydell
2015-01-30 11:39                     ` Laszlo Ersek
2015-01-30 11:42                       ` Peter Maydell
2015-01-30 11:38                   ` Laszlo Ersek [this message]
2015-01-30 11:40                     ` Peter Maydell
2015-01-30 11:48                       ` Laszlo Ersek
2015-01-30 11:50                         ` Peter Maydell
2015-01-29 19:09     ` Richard W.M. Jones
2015-01-29 19:28       ` Peter Maydell
2015-01-29 19:35       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CB6D36.9070305@redhat.com \
    --to=lersek@redhat.com \
    --cc=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).