From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHA4Q-0001jG-6Y for qemu-devel@nongnu.org; Fri, 30 Jan 2015 06:49:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHA4M-0003SF-62 for qemu-devel@nongnu.org; Fri, 30 Jan 2015 06:49:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHA4L-0003S8-VA for qemu-devel@nongnu.org; Fri, 30 Jan 2015 06:49:02 -0500 Message-ID: <54CB6FA7.5040701@redhat.com> Date: Fri, 30 Jan 2015 12:48:55 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <54CA6CF6.7090308@redhat.com> <54CA7BF5.8020800@redhat.com> <54CA8637.2080306@redhat.com> <54CA8E37.8070009@redhat.com> <20150130095456.GB27572@redhat.com> <20150130104833.GC27572@redhat.com> <54CB6D36.9070305@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] address order of virtio-mmio devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu devel list On 01/30/15 12:40, Peter Maydell wrote: > On 30 January 2015 at 11:38, Laszlo Ersek wrote: >> Please note that (as far as I understand) the patch that I referenced is >> indeed very new, it's not part of v3.18, but the reversal can easily be >> seen with v3.18. In other words, the kernel patch I referenced >> introduces no functional change, it just reorganizes stuff in the kernel >> (AIUI), with the benefit of killing a superfluous field. >> >> The reason I referenced it because its *commit message* gives good >> background. If we really wanted to find the kernel change that reversed >> the traversal, we'd have to talk to Grant and/or bisect the kernel. > > Just as a sanity check, do we actually have an old kernel that > enumerates in the opposite order (as opposed to my two-year-old > "I'm sure this used to be right" memories...) ? I never saw one. :) That's why I asked in my first message if anyone had actually tested that loop / comment. Thanks, Laszlo