From: Max Reitz <mreitz@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/4] blockdev: Give find_block_job() an Error ** parameter
Date: Fri, 30 Jan 2015 10:10:22 -0500 [thread overview]
Message-ID: <54CB9EDE.3030700@redhat.com> (raw)
In-Reply-To: <1422524221-8566-2-git-send-email-armbru@redhat.com>
On 2015-01-29 at 04:36, Markus Armbruster wrote:
> When find_block_job() fails, all its callers build the same Error
> object. Build it in find_block_job() instead.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> blockdev.c | 19 ++++++++-----------
> 1 file changed, 8 insertions(+), 11 deletions(-)
I think I'd like it better to return "Device not found" in case
bdrv_find() fails, but that's probably a matter of taste:
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2015-01-30 15:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 9:36 [Qemu-devel] [PATCH v2 0/4] block: Cleanups around error reporting Markus Armbruster
2015-01-29 9:36 ` [Qemu-devel] [PATCH v2 1/4] blockdev: Give find_block_job() an Error ** parameter Markus Armbruster
2015-01-30 15:10 ` Max Reitz [this message]
2015-02-02 9:21 ` Markus Armbruster
2015-01-29 9:36 ` [Qemu-devel] [PATCH v2 2/4] blockdev: Eliminate silly QERR_BLOCK_JOB_NOT_ACTIVE macro Markus Armbruster
2015-01-30 15:14 ` Max Reitz
2015-01-29 9:37 ` [Qemu-devel] [PATCH v2 3/4] block: New bdrv_add_key(), convert monitor to use it Markus Armbruster
2015-01-30 15:18 ` Max Reitz
2015-01-29 9:37 ` [Qemu-devel] [PATCH v2 4/4] block: Eliminate silly QERR_ macros used for encryption keys Markus Armbruster
2015-01-30 15:20 ` Max Reitz
2015-02-02 17:52 ` [Qemu-devel] [PATCH v2 0/4] block: Cleanups around error reporting Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CB9EDE.3030700@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).