From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHDDG-0000jH-FQ for qemu-devel@nongnu.org; Fri, 30 Jan 2015 10:10:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHDDD-00014x-R8 for qemu-devel@nongnu.org; Fri, 30 Jan 2015 10:10:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHDDD-00014i-K3 for qemu-devel@nongnu.org; Fri, 30 Jan 2015 10:10:23 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0UFAN2v022064 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 30 Jan 2015 10:10:23 -0500 Message-ID: <54CB9EDE.3030700@redhat.com> Date: Fri, 30 Jan 2015 10:10:22 -0500 From: Max Reitz MIME-Version: 1.0 References: <1422524221-8566-1-git-send-email-armbru@redhat.com> <1422524221-8566-2-git-send-email-armbru@redhat.com> In-Reply-To: <1422524221-8566-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/4] blockdev: Give find_block_job() an Error ** parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com On 2015-01-29 at 04:36, Markus Armbruster wrote: > When find_block_job() fails, all its callers build the same Error > object. Build it in find_block_job() instead. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > blockdev.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) I think I'd like it better to return "Device not found" in case bdrv_find() fails, but that's probably a matter of taste: Reviewed-by: Max Reitz