From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58278)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YHDGw-0003ds-W9
	for qemu-devel@nongnu.org; Fri, 30 Jan 2015 10:14:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YHDGu-0002cA-A3
	for qemu-devel@nongnu.org; Fri, 30 Jan 2015 10:14:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37981)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YHDGu-0002by-2o
	for qemu-devel@nongnu.org; Fri, 30 Jan 2015 10:14:12 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0UFEA2Y014609
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Fri, 30 Jan 2015 10:14:11 -0500
Message-ID: <54CB9FC1.7030804@redhat.com>
Date: Fri, 30 Jan 2015 10:14:09 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1422524221-8566-1-git-send-email-armbru@redhat.com>
	<1422524221-8566-3-git-send-email-armbru@redhat.com>
In-Reply-To: <1422524221-8566-3-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/4] blockdev: Eliminate silly
 QERR_BLOCK_JOB_NOT_ACTIVE macro
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com

On 2015-01-29 at 04:36, Markus Armbruster wrote:
> From: Markus Armbruster <armbru@pond.sub.org>

Intentional?

> The QERR_ macros are leftovers from the days of "rich" error objects.
> They're used with error_set() and qerror_report(), and expand into the
> first *two* arguments.  This trickiness has become pointless.  Clean
> this one up.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>   blockdev.c                | 3 ++-
>   include/qapi/qmp/qerror.h | 3 ---
>   2 files changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>