From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHDXB-0002RH-NS for qemu-devel@nongnu.org; Fri, 30 Jan 2015 10:31:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHDX8-0000SF-I0 for qemu-devel@nongnu.org; Fri, 30 Jan 2015 10:31:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHDX8-0000S7-Bb for qemu-devel@nongnu.org; Fri, 30 Jan 2015 10:30:58 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0UFUvqt003593 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 30 Jan 2015 10:30:57 -0500 Message-ID: <54CBA3B0.70503@redhat.com> Date: Fri, 30 Jan 2015 10:30:56 -0500 From: Max Reitz MIME-Version: 1.0 References: <1422586186-9925-1-git-send-email-famz@redhat.com> <1422586186-9925-6-git-send-email-famz@redhat.com> In-Reply-To: <1422586186-9925-6-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 5/5] qemu-iotests: Add 093 for IO throttling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 2015-01-29 at 21:49, Fam Zheng wrote: > This case utilizes qemu-io command "aio_{read,write} -q" to verify the > effectiveness of IO throttling options. > > It's implemented by driving the vm timer from qtest protocol, so the > throttling timers are signaled with determinied time duration. Then we > verify the completed IO requests are within 10% error of bps and iops > limits. > > "null" protocol is used as the disk backend so that no actual disk IO is > performed on host, this will make the blockstats much more > deterministic. Both "null-aio" and "null-co" are covered, which is also > a simple cross validation test for the driver code. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/093 | 114 +++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/093.out | 5 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 120 insertions(+) > create mode 100755 tests/qemu-iotests/093 > create mode 100644 tests/qemu-iotests/093.out Reviewed-by: Max Reitz