From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHFiq-0008Cg-5D for qemu-devel@nongnu.org; Fri, 30 Jan 2015 12:51:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHFim-0006Ot-5F for qemu-devel@nongnu.org; Fri, 30 Jan 2015 12:51:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43733) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHFil-0006Oj-UK for qemu-devel@nongnu.org; Fri, 30 Jan 2015 12:51:08 -0500 Message-ID: <54CBC487.1090700@redhat.com> Date: Fri, 30 Jan 2015 10:51:03 -0700 From: Eric Blake MIME-Version: 1.0 References: <1421168546-6232-1-git-send-email-vsementsov@parallels.com> <1421168546-6232-8-git-send-email-vsementsov@parallels.com> <54C7B48A.4030606@redhat.com> <54CB49A6.4030302@parallels.com> In-Reply-To: <54CB49A6.4030302@parallels.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MqpBTHrCgRk0mxgjRvA388rs3mClQa9jp" Subject: Re: [Qemu-devel] [PATCH 7/8] qmp: print dirty bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MqpBTHrCgRk0mxgjRvA388rs3mClQa9jp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/30/2015 02:06 AM, Vladimir Sementsov-Ogievskiy wrote: > is it better to add qmp_query_dirty_bitmap with underlying > bdrv_query_dirty_bitmap, or to modify (add dirty regions information) > existing qmp_query_block/qmp_query_dirty_bitmapS? [please don't top-post on technical lists] Extending an existing command may be reasonable, if the amount of information being added is compact (if you are adding several kilobytes of information, that might justify a new command, if only so that old callers don't waste time receiving large amounts of data on the wire just to sift through and discard it all to get at the older content they cared about). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MqpBTHrCgRk0mxgjRvA388rs3mClQa9jp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUy8SHAAoJEKeha0olJ0Nqh3oH/jMvYATQ+8NU4tG7gDJW1jYM 1fawx7nruI8S4lxcvGzV80DjscIj4OSnNC/e5ACrH9Egtm59/qbF+hYu9cDiHVPw hzWOxJP2VYLCSfebnSyEkuxjWlWEvtStX9bw9xl1y5hEFAm9e/En38vCFdpb2xnO 2gTTOnW8mKl0OIAPOUcng4svHma1LduTQXJoJnzXYAO3J/vEinnEnfMYsP4ACM9c o54NFR9WxphjNkvSt6vSQ6ARNvCivlpSaIOeUmDz2AAMHLFvr1sEXwZT4iw58x3S pB3YMX1N/pVi2YCA28gsApNdZXo9A8Cxq/b+oL3dNOnQuH9Ejn6JqCmuxGXCa/o= =giUx -----END PGP SIGNATURE----- --MqpBTHrCgRk0mxgjRvA388rs3mClQa9jp--