From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI56l-0000qr-Nf for qemu-devel@nongnu.org; Sun, 01 Feb 2015 19:43:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YI56g-0001vH-IQ for qemu-devel@nongnu.org; Sun, 01 Feb 2015 19:43:19 -0500 Received: from mga09.intel.com ([134.134.136.24]:38037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI56g-0001ul-C7 for qemu-devel@nongnu.org; Sun, 01 Feb 2015 19:43:14 -0500 Message-ID: <54CEC81C.2090604@intel.com> Date: Mon, 02 Feb 2015 08:43:08 +0800 From: "Chen, Tiejun" MIME-Version: 1.0 References: <1421848132.11160.44.camel@nilsson.home.kraxel.org> <54C0498D.1030603@intel.com> <54C19936.1060804@intel.com> <54C58DF2.2090509@intel.com> <21703.41796.519916.252197@mariner.uk.xensource.com> <54C83090.2080202@intel.com> <20150128111219.GN24026@zion.uk.xensource.com> <54C981B4.5070205@intel.com> <20150129105052.GB20229@zion.uk.xensource.com> <54CAD6D0.6060100@intel.com> <20150130122613.GB6334@zion.uk.xensource.com> In-Reply-To: <20150130122613.GB6334@zion.uk.xensource.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Liu Cc: ian.campbell@citrix.com, "mst@redhat.com" , Ian Jackson , qemu-devel@nongnu.org, xen-devel@lists.xen.org, Gerd Hoffmann On 2015/1/30 20:26, Wei Liu wrote: > On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote: > [...] >>>>> >>>>> Just remember to handle old option in libxl if your old option is already >>>>> released by some older version of QEMUs. >>>> >>>> I just drop that old option, -gfx_passthru, if we're under qemu upstream >>>> circumstance, like this, >>>> >>> >>> The question is, is there any version of qemu upstream that has >>> been released that has the old option (-gfx-passthru)? >> >> No. Just now we're starting to support IGD passthrough in qemu upstream. >> > > Right, as of QEMU 2.2.0 there's no support of IGD passthrough in QMEU > upstream. > >>> >>> This gives us a situation that we need to support both the old >>> (-gfx-passthru) and new (-igd-passthru) options. Presumably we (libxl) >>> would need to fork a qemu process to determine which option it has and >>> pass the right one. >>> >>> Or you can try to keep both old and new option at the same time but >> >> Yeah, actually I also have considered to keep both two options at the same >> time. Its really friendly to any qemu version. >> >>> deprecate the old one. Then in a few qemu release cycles later (or >> >> This should be like 'accel=kvm' versus 'enable-kvm' in qemu upstream. >> They're coexisted now but just the former is a modern option. >> >>> probably one year or two?) you can finally remove the old one. The point >>> is that to give downstream (in this case, Xen) time to cope with the >>> change. >> >> Here I'm fine to this way. >> >> So Gerd, >> > > So you don't actually need to ask Gerd this question because there is no > old option to keep in qemu upstream. > > Libxl (or any sensible toolstack) will just do the right thing to either > pass -igd-passthru (or whatever you guys agree upon) to qemu upstream or > pass -gfx-passthru to qemu traditional. :-) > Okay let me try do this. Thanks Tiejun