From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50230)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YIEBw-0006RH-QR
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:25:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YIEBs-0006E6-Qe
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:25:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46525)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YIEBs-0006Dw-JX
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 05:25:12 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t12APAXO028209
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Mon, 2 Feb 2015 05:25:11 -0500
Message-ID: <54CF5081.1000308@redhat.com>
Date: Mon, 02 Feb 2015 11:25:05 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1422643333-27926-1-git-send-email-jsnow@redhat.com>
	<1422643333-27926-4-git-send-email-jsnow@redhat.com>
In-Reply-To: <1422643333-27926-4-git-send-email-jsnow@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/19] qtest/ahci: rename 'Command' to
	'CommandHeader'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mst@redhat.com



On 30/01/2015 19:41, John Snow wrote:
> @@ -703,8 +703,8 @@ static void ahci_test_identify(AHCIQState *ahci)
>      /* Copy the existing Command #0 structure from the CLB into local memory,
>       * and build a new command #0. */
>      memread(ahci->port[i].clb, &cmd, sizeof(cmd));
> -    cmd.b1 = 5;    /* reg_h2d_fis is 5 double-words long */
> -    cmd.b2 = 0x04; /* clear PxTFD.STS.BSY when done */
> +    cmd.flags = 5;    /* reg_h2d_fis is 5 double-words long */
> +    cmd.flags |= 0x400; /* clear PxTFD.STS.BSY when done */

Missing cpu_to_le16, I think.

Paolo